Migrate local pipeline + non-release CI from dfx to icp-cli#550
Open
Kamirus wants to merge 3 commits into
Open
Migrate local pipeline + non-release CI from dfx to icp-cli#550Kamirus wants to merge 3 commits into
Kamirus wants to merge 3 commits into
Conversation
…-cli Switch `npm run replica`/`deploy-local` and the corresponding ci.yml steps to icp-cli + pocket-ic; mops-test.yml now relies on `[toolchain].pocket-ic` in mops.toml instead of dfx. Production deploys (release.yml, deploy-staging, deploy-ic) and `dfx generate` for declarations stay on dfx. LANG-1311 Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Cursor AI review👍 APPROVE — looks safe to merge
VerdictDecision: APPROVE Generated for commit 5a9448e |
mops 1.0.0 (tested by setup-mops.yml and mops-test.yml matrix) only supports pocket-ic 4.0.0. Adding pocket-ic = 12.0.0 to root mops.toml breaks 'mops test' for old CLIs in those matrices. Keeps icp.yaml + ci.yml/package.json/vite migration; mops-test.yml stays on dfx for now. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes for users
Mops contributors:
npm run replica,npm run deploy-localandnpm startnow useicp-cli+pocket-icinstead ofdfx. Local dev requiresnpm install -g @icp-sdk/icp-cli @icp-sdk/ic-wasm(Node-based install, see icp-cli quickstart).ci.ymlinstallsicp-clialongsidedfxand exercises the new local pipeline end-to-end.What stays on dfx:
release.yml,npm run deploy-staging,npm run deploy-ic.npm run decl:cli(dfx generate) — switching toicp-bindgenwould generate a noisy churn diff incli/declarations/; deferred.mops-test.ymlandsetup-mops.ymlmatrices: they test againstmops@1.0.0, which only supports pocket-ic 4.0.0 and so can't pick up a newer[toolchain].pocket-icfrom this repo's mops.toml.dfx.jsonis kept so the production paths and external mops users are unaffected.End users of the
ic-mopsCLI itself: no change.Why
Reduce internal coupling to dfx ahead of broader migration (LANG-1311). Picks the safe, low-blast-radius targets first (local dev + ci.yml) and leaves mainnet-touching paths and old-CLI matrices alone.
How it was validated
Locally exercised the full chain on macOS:
vite.config.tsreads the new flat icp ids map ({ name: id }) forlocal, with a fallback to.dfx/local/canister_ids.jsonso anyone still on the dfx pipeline locally is unaffected during the transition.Notes
icp.yamlmirrorsdfx.json;cliandplay-frontenduse raw build/sync steps because the asset-canister recipe template only supports a singledir.mops-test.ymlvia[toolchain].pocket-ic = "12.0.0"in root mops.toml failed CI: the matrix testsmops@1.0.0, which errors with "Current Mops CLI only supports pocket-ic 4.0.0". Reverted in a follow-up commit on this PR.