fix: align mixin stab list with desugared IR order in IncludeD#6167
Open
Kamirus wants to merge 1 commit into
Open
fix: align mixin stab list with desugared IR order in IncludeD#6167Kamirus wants to merge 1 commit into
Kamirus wants to merge 1 commit into
Conversation
`build_stabs` for `IncludeD` emitted `[letP_flex; imports...; mixin_decs...]` while `dec'` emits `[imports...; letP; mixin_decs...]`, so the subsequent `List.map2 stabilize stabs ds` paired the letP stab with the first import dec (and shifted each import stab onto the next dec). Currently benign because every stab in that segment is `Some Flexible` and `stabilize` treats `Flexible` as identity, but it is a latent bug the moment any of those stabs becomes anything else. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Cursor AI review👍 APPROVE — looks safe to merge
VerdictDecision: APPROVE Generated for commit a8c0420 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_stabsforIncludeDproduced[letP_flex; imports...; mixin_decs...]whiledec'emits[imports...; letP; mixin_decs...], soList.map2 stabilize stabs dspaired the letP stab with the first import dec and shifted each import stab onto the next dec.Benign today (every stab in that segment is
Some Flexibleandstabilizeis identity onFlexible), but a latent footgun the moment any of those stabs becomes anything other thanFlexible.Made with Cursor