Skip to content

Support for application/x-www-form-urlencoded - #32

Open
ilndinesh wants to merge 1 commit into
cagataygurturk:masterfrom
dineshbjn:x-www-form-urlencoded
Open

Support for application/x-www-form-urlencoded#32
ilndinesh wants to merge 1 commit into
cagataygurturk:masterfrom
dineshbjn:x-www-form-urlencoded

Conversation

@ilndinesh

Copy link
Copy Markdown

For the requests that come to API gateway with type - "application/x-www-form-urlencoded", I have added a new mapping in a file and applied it during AWS deploy

The other changes are only formatting ones.

@arranubels

Copy link
Copy Markdown

Hi ilndinesh,

Test aren't passing in org.lambadaframework.jaxrs.JAXRSParserTest.

Regards,
Arran

@arranubels

arranubels commented Oct 3, 2016

Copy link
Copy Markdown

Hi Ilndinesh,

I have attempted to merge this with my PR in https://github.com/arranubels/lambadaframework/tree/pr4

However there was a part I didn't understand. Please review:
https://github.com/bluejeansnet/lambadaframework/compare/x-www-form-urlencoded...arranubels:pr4?expand=1#diff-4d1cba0c8fbb262270c557610751811eR137

Thanks.

Regards,
Arran

P.S. Also we need to fix the tests, it would also be a good idea to add some more tests. (I plan to do so too.)

@ilndinesh

Copy link
Copy Markdown
Author

Hi Arran,

https://github.com/bluejeansnet/lambadaframework/compare/x-www-form-urlencoded...arranubels:pr4?expand=1#diff-4d1cba0c8fbb262270c557610751811eR137

The above diff line is straight forward cast of request body to "String" iff the body is instance of "String". Were you looking explanation for some other diff?

@arran4

arran4 commented Oct 4, 2016

Copy link
Copy Markdown

Hi Ilndinesh,

Yes. I made another push.. Can you verify I have integrated your code correctly?

I left the thread as is as the position is still a point of interest.

Regards,
Arran

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants