Fix: discard workout instead of saving when pressing back button - #10
Merged
Conversation
When pressing the back button to exit, the workout is now properly discarded instead of being automatically saved. This matches the user expectation of canceling the activity when pressing back. The onBack() function now checks if there's an active recording session and calls session.discard() before exiting, similar to the existing behavior in onSelect().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pressing the back button to exit, the workout is now properly
discarded instead of being automatically saved. This matches the user
expectation of canceling the activity when pressing back.
The onBack() function now checks if there's an active recording session
and calls session.discard() before exiting, similar to the existing
behavior in onSelect().