Fix type checking errors for GitHub workflow - #12
Open
cagnulein wants to merge 4 commits into
Open
Conversation
Add explicit type annotations to resolve strict type checking errors that occur in the GitHub workflow CI/CD pipeline. Changes include: - CommsRelay.mc: Add types for mCallback and method parameters - Log.mc: Add types for logLevel and all message parameters - QZCompanionGarminDelegate.mc: Add type for session variable - QZCompanionGarminView.mc: Add types for all member variables and add null checks before accessing Activity info properties These changes ensure compatibility with strict type checking while maintaining backward compatibility with existing functionality.
Remove return type annotations from initialize() constructors and remove explicit type annotations from local variables, as these are not allowed in MonkeyC: - Constructors cannot have return type annotations - Local variable types are inferred, not explicitly declared Changes: - CommsRelay.mc: Remove 'as Void' from initialize() - Log.mc: Remove 'as Void' from initialize() - QZCompanionGarminView.mc: Remove 'as String' from local vars
Add :disableGps=>true parameter to both indoor running and cycling activity recording sessions. This saves battery life since GPS is not needed for indoor workouts. Merged changes from PR #11
MonkeyC requires all basic types to be qualified with the Lang prefix. Changed: - Number -> Lang.Number - String -> Lang.String - Float -> Lang.Float - Boolean -> Lang.Boolean - Array -> Lang.Array - Dictionary -> Lang.Dictionary This fixes "Cannot resolve type" errors in the workflow build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add explicit type annotations to resolve strict type checking errors
that occur in the GitHub workflow CI/CD pipeline. Changes include:
add null checks before accessing Activity info properties
These changes ensure compatibility with strict type checking while
maintaining backward compatibility with existing functionality.