octane zr8 speed filter - #3926
Merged
Merged
Conversation
Owner
Author
Refines cadence processing by updating Cadence only if the value is >= 30 to filter out noise. Adds logic to detect when cadence drops to 0 and, if it remains at 0 for 5 seconds, resets the speed to 0, with debug messages for state changes. Introduces lastCadenceZeroTime to track the duration of zero cadence events.
Deleted the unused TestOctaneTreadmillZR8.cpp file and updated TestOctaneTreadmillZR8.h to include octane_test_dataset.h instead of the .cpp. Also updated the test project file to remove the deleted source file and renamed octane_test_dataset.cpp to octane_test_dataset.h.
This reverts commit e8b4986.
Enhanced the ZR8 mode in octanetreadmill to strictly validate packet headers, reject incomplete or corrupted packets, and add detailed debug logging for packet processing. Added a method to activate ZR8 parsing mode and updated tests to enable this mode. Also fixed Bluetooth device name matching to be case-insensitive for certain devices.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.