Add speed and inclination +/- buttons to floating template - #4258
Merged
Conversation
Add new control tiles for speed and inclination in the floating template (both vertical and horizontal variants). These tiles display the current value with +/- buttons for adjustment, useful for treadmill users who want to control speed and incline from the floating overlay. Changes: - Add speedcontrol and inclinecontrol tiles to floating.htm and hfloating.htm - Add SpeedPlus/SpeedMinus and InclinationPlus/InclinationMinus JavaScript functions - Add WebSocket message handlers (speed_plus, speed_minus, inclination_plus, inclination_minus) - Add corresponding signals and slots in templateinfosenderbuilder and homeform - Wire up to existing Plus/Minus functions which handle speed and inclination changes https://claude.ai/code/session_01QgLyRenM7sSWqqGU1Esy3s
Replace AVG/MAX labels with -/+ buttons on speed and inclination rows instead of having separate control tiles. This provides a cleaner UI where users can see all metrics (avg, current, max) while also having control buttons on the same row. Layout: [-] AVG_VALUE | CURRENT_VALUE | [+] MAX_VALUE https://claude.ai/code/session_01QgLyRenM7sSWqqGU1Esy3s
Add small labels under the avg and max values so users know what
the values represent. Layout is now:
[-] avg_value | current_value | [+] max_value
AVG MAX
https://claude.ai/code/session_01QgLyRenM7sSWqqGU1Esy3s
The +/- control buttons on speed and inclination rows are now only visible when connected to a treadmill device. For other device types (bike, elliptical, etc.), the standard AVG/MAX labels are shown instead. Uses deviceType and TREADMILL_TYPE from workout data to detect the device type and toggle visibility via CSS classes. https://claude.ai/code/session_01QgLyRenM7sSWqqGU1Esy3s
Wrap the <br> and AVG/MAX label elements together in a span with the treadmill-only class so they are both hidden for non-treadmill devices. This ensures the table layout is identical to the original for bikes and other non-treadmill equipment. https://claude.ai/code/session_01QgLyRenM7sSWqqGU1Esy3s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new control tiles for speed and inclination in the floating
template (both vertical and horizontal variants). These tiles display
the current value with +/- buttons for adjustment, useful for treadmill
users who want to control speed and incline from the floating overlay.
Changes:
https://claude.ai/code/session_01QgLyRenM7sSWqqGU1Esy3s