Remove blocking loop.exec write flow from ftmsbike - #4382
Merged
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Closed
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Owner
Author
|
rschumakerjr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
QEventLoop::exec()nelle scritture BLE diftmsbikeper evitare loop annidati e blocchi simili a quanto già fatto per il treadmill Domyos.Description
WriteRequeste da metodienqueueWrite,processWriteQueueecompleteCurrentWriteinftmsbike.writeCharacteristicZwiftPlay(...)ewriteCharacteristic(...)per usare la coda invece di creare e bloccare conQEventLoop.QQueue<WriteRequest>, flag di stato (isWriting,currentWriteWaitingForResponse,currentWriteService) e unQTimerwriteTimeoutTimerper avanzare la coda su timeout.characteristicChangedcompleta le scritture che aspettano una risposta echaracteristicWrittencompleta quelle che non aspettano risposta.Testing
loop.exec/QEventLoopsu sorgenteftmsbikeeseguita e non sono state trovate occorrenze, test superato.git diff,git status) e hanno mostrato le modifiche attese, test superato.Codex Task