Skip to content

Add FS-YK device support and correct FTMS resistance/inclination encoding #4537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cagnulein merged 9 commits into from
May 19, 2026
Merged

Add FS-YK device support and correct FTMS resistance/inclination encoding #4537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d255c53
ftmsbike: set FS-YK max resistance to 21 levels
cagnulein Apr 15, 2026
3537e44
Increase max resistance for FS-YK bike to 24
cagnulein Apr 16, 2026
1f27849
Update ftmsbike.h
cagnulein Apr 18, 2026
9765e57
Merge branch 'master' into codex/fix-resistance-value-for-fs-yk-bike
cagnulein Apr 18, 2026
528a5a9
fixing overwrite resistance
cagnulein Apr 19, 2026
d06d8dd
Update ftmsbike.cpp
cagnulein Apr 23, 2026
ae5af86
Merge branch 'master' into codex/fix-resistance-value-for-fs-yk-bike
cagnulein Apr 23, 2026
2db29d8
Update ftmsbike.cpp
cagnulein Apr 23, 2026
5a7124e
Merge branch 'master' into codex/fix-resistance-value-for-fs-yk-bike
cagnulein May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions src/devices/ftmsbike/ftmsbike.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,10 +269,10 @@ void ftmsbike::forceResistance(resistance_t requestResistance) {
requestResistance = 1;
}

if(SL010 || SPORT01 || TOPUTURE_TEB5)
if(SL010 || SPORT01 || TOPUTURE_TEB5 || FS_YK)
Resistance = requestResistance;

if(JFBK5_0 || DIRETO_XR || YPBM || FIT_BK || ZIPRO_RAVE || SPEEDRACEX || MRK_S28 || USDC_D700) {
if(JFBK5_0 || DIRETO_XR || YPBM || FIT_BK || ZIPRO_RAVE || SPEEDRACEX || MRK_S28 || USDC_D700 || FS_YK) {
uint8_t write[] = {FTMS_SET_TARGET_RESISTANCE_LEVEL, 0x00, 0x00};
write[1] = ((uint16_t)requestResistance * 10) & 0xFF;
write[2] = ((uint16_t)requestResistance * 10) >> 8;
Expand Down Expand Up @@ -825,7 +825,7 @@ void ftmsbike::characteristicChanged(const QLowEnergyCharacteristic &characteris
if(BIKE_)
d = d / 10.0;
// for this bike, i will use the resistance that I set directly because the bike sends a different ratio.
if(!SL010 && !TITAN_7000 && !SPORT01 && !TOPUTURE_TEB5) {
if(!SL010 && !TITAN_7000 && !SPORT01 && !TOPUTURE_TEB5 && !FS_YK) {
Resistance = d;
native_resistance_received = true;
calculatedResistanceFallbackSince = QDateTime();
Expand Down Expand Up @@ -863,7 +863,7 @@ void ftmsbike::characteristicChanged(const QLowEnergyCharacteristic &characteris
m_pelotonResistance = res;
}

if (!resistance_received && !DU30_bike && !SL010 &&
if (!resistance_received && !DU30_bike && !SL010 && !FS_YK &&
shouldUseCalculatedResistanceFallback(now)) {
Resistance = m_pelotonResistance;
emit resistanceRead(Resistance.value());
Expand Down Expand Up @@ -1178,13 +1178,15 @@ void ftmsbike::characteristicChanged(const QLowEnergyCharacteristic &characteris

qDebug() << QStringLiteral("Current Peloton Resistance: ") + QString::number(m_pelotonResistance.value());

if (settings.value(QZSettings::schwinn_bike_resistance, QZSettings::default_schwinn_bike_resistance)
.toBool())
Resistance = pelotonToBikeResistance(m_pelotonResistance.value());
else
Resistance = m_pelotonResistance;
emit resistanceRead(Resistance.value());
qDebug() << QStringLiteral("Current Resistance Calculated: ") + QString::number(Resistance.value());
if (!FS_YK) {
if (settings.value(QZSettings::schwinn_bike_resistance, QZSettings::default_schwinn_bike_resistance)
.toBool())
Resistance = pelotonToBikeResistance(m_pelotonResistance.value());
else
Resistance = m_pelotonResistance;
emit resistanceRead(Resistance.value());
qDebug() << QStringLiteral("Current Resistance Calculated: ") + QString::number(Resistance.value());
}

if (watts())
KCal +=
Expand Down Expand Up @@ -1331,7 +1333,7 @@ void ftmsbike::characteristicChanged(const QLowEnergyCharacteristic &characteris
if (!ensureBytesAvailable(2, QStringLiteral("resistance")))
return;

if(!TITAN_7000) {
if(!TITAN_7000 && !FS_YK) {
Resistance = ((double)(((uint16_t)((uint8_t)newValue.at(index + 1)) << 8) |
(uint16_t)((uint8_t)newValue.at(index))));
emit resistanceRead(Resistance.value());
Expand Down Expand Up @@ -1370,7 +1372,7 @@ void ftmsbike::characteristicChanged(const QLowEnergyCharacteristic &characteris
m_pelotonResistance = res;
}

if (shouldUseCalculatedResistanceFallback(now)) {
if (!FS_YK && shouldUseCalculatedResistanceFallback(now)) {
Resistance = m_pelotonResistance;
emit resistanceRead(Resistance.value());
emit debug(QStringLiteral("Current Resistance (calculated fallback): ") +
Expand Down Expand Up @@ -2051,7 +2053,9 @@ void ftmsbike::deviceDiscovered(const QBluetoothDeviceInfo &device) {
} else if(device.name().toUpper().startsWith("FS-YK-")) {
qDebug() << QStringLiteral("FS-YK- found");
FS_YK = true;
resistance_lvl_mode = true;
ergModeSupported = false; // this bike doesn't have ERG mode natively
max_resistance = 24;
} else if(device.name().compare(QStringLiteral("S18"), Qt::CaseInsensitive) == 0) {
qDebug() << QStringLiteral("S18 found");
S18 = true;
Expand Down
6 changes: 4 additions & 2 deletions src/devices/ftmsbike/ftmsbike.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,10 @@ class ftmsbike : public bike {
double maxGears() override;
double minGears() override;

// true because or the bike supports it by hardware or because QZ is emulating this in this module
bool ergModeSupportedAvailableBySoftware() override { return true; }
// Most FTMS bikes can use QZ's software ERG emulation, but FS-YK devices
// should stay on direct resistance control because it doesn't send the current resistance value and it conflicts
// with the PID HR method
bool ergModeSupportedAvailableBySoftware() override { return !FS_YK; }
bool inclinationAvailableBySoftware() override { return !resistance_lvl_mode; }

private:
Expand Down
Loading