Add Echelon BLE proxy & advertising support for virtual rower and treadmill - #4581
Open
cagnulein wants to merge 18 commits into
Open
Add Echelon BLE proxy & advertising support for virtual rower and treadmill#4581cagnulein wants to merge 18 commits into
cagnulein wants to merge 18 commits into
Conversation
…' of https://github.com/cagnulein/qdomyos-zwift into codex/implement-firmware-unlock-for-treadmill-and-rower
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This reverts commit 7073630.
The iOS Peloton cadence workaround (lockscreen virtualbike_ios) must not start for fake rower, fake treadmill and the real echelon rower when the virtual Echelon device is enabled, otherwise it conflicts with the Echelon emulation. echelonstride has no Peloton workaround so it needs no guard. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Owner
Author
|
Fake rower works! |
Owner
Author
trim.D2465FD1-AF10-4D78-9F89-244D5F01677D.MOV |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
virtual_device_echelon).Description
virtualrowerandvirtualtreadmilladvertising: newserviceDataEchelon/serviceEchelonwith write characteristic0bf669f2-...and notify characteristics0bf669f3-.../0bf669f4-..., and conditional inclusion controlled byQZSettings::virtual_device_echelon.proxyVirtualRowerCommandandproxyVirtualTreadmillCommandinechelonrower/echelonstrideto write incoming virtual-device commands to the real device, and call these from the virtual device when a real Echelon device is connected.relayEchelonPacketimplementations invirtualrowerandvirtualtreadmillto forward notifications from a connected real Echelon device to the corresponding virtual notify characteristics so connected clients receive real-device updates.characteristicChangedinechelonrowerandechelonstrideto any attached virtual device viadynamic_castandrelayEchelonPacket.Testing
make) after the changes and the build completed successfully.Codex Task