Skip to content

Detailed Bug Report: Running Workout Incline Parsing Issue & CORE Sensor Garmin Sync Failure - #4663

Merged
cagnulein merged 29 commits into
masterfrom
Detailed-Bug-Report-Running-Workout-Incline-Parsing-Issue-CORE-Sensor-Garmin-Sync-Failure
Jun 9, 2026
Merged

Detailed Bug Report: Running Workout Incline Parsing Issue & CORE Sensor Garmin Sync Failure #4663
cagnulein merged 29 commits into
masterfrom
Detailed-Bug-Report-Running-Workout-Incline-Parsing-Issue-CORE-Sensor-Garmin-Sync-Failure

Conversation

@cagnulein

@cagnulein cagnulein commented May 27, 2026

Copy link
Copy Markdown
Owner

Summary

Bug fixes

  • Incline parsing (ZWO/XML): fixed incorrect ×100 multiplication applied to incline values already expressed as percentages. The new normalizeIncline heuristic (threshold ≤0.40) correctly handles both fraction-encoded files (e.g. Incline="0.02" = 2%) and percent-encoded files (e.g. Incline="2.0" = 2%), covering realistic treadmill inclines up to 40%.
  • Garmin workout download: fixed crash/miss when a scheduled workout (itemType="workout") had no workoutUuid — these now use the schedule id field instead.
  • Garmin multi-workout prompt: fixed race condition where downloading multiple workouts in the same session would overwrite the prompt — workouts are now queued and shown one at a time.

New features

  • CORE sensor Garmin sync: FIT files now include CORE body temperature data with the correct CORE app UUID (6957fe68-83fe-4ed6-8613-413f70624bb5) and full field set (core/skin temperature, heat strain index, CIQ fields, lap and session summaries) recognized by Garmin Connect.
  • Garmin workout filename includes sport suffix: downloaded workouts are saved as date - name_Run.xml / _Ride.xml etc., preventing same-day run/ride name collisions.
  • Garmin download on startup toggle: new setting garmin_download_workouts_on_start (default: enabled) to control whether QZ auto-fetches today's Garmin workout at launch.
  • Multiple Garmin workouts per day: the fallback calendar lookup now downloads all workouts tied to the nearest scheduled day instead of only the first one found.
  • XML files with ZWO content: .xml files whose root element is <workout_file> or <Workout> are now parsed by the Zwift workout engine, not the QZ XML parser. Detection is done by reading the root element, no extension rename needed.
  • <Step> element support in ZWO/XML: new direct-speed step format (<Step Duration="120" Speed="6.0" Incline="2"/>) is now parsed for running workouts.
  • SteadyState with direct Speed: when a SteadyState block carries a Speed attribute and the sport is running, speed is applied directly in km/h instead of being converted from power/pace.
  • Clipboard workout detection: new opt-in setting trainprogram_clipboard_workout_enabled (default: disabled). When active, QZ polls the clipboard every 5 seconds; if a valid ZWO or QZ XML workout is detected, the user is prompted to open it. At workout end, QZ asks whether to delete the temporary file.
  • Paste from clipboard in Workout Editor: new "Paste from Clipboard" button in the embedded workout editor allows pasting a QZ XML workout directly from the clipboard.
  • Delete workout from UI: the Training Programs list now includes a Delete button with confirmation dialog. Deletion is restricted to files inside the training/ folder (path traversal protected).
  • Recursive workout listing: the Training Programs list now shows workouts from all subfolders (e.g. run/Garmin/, ride/Garmin/) with relative path display, not only the top-level training/ directory.

Tests

  • Added ZwiftWorkoutTestSuite: covers percent/fraction incline parsing, negative incline, direct Speed attribute, <Step> format, and .xml extension auto-detection.
  • Added Garmin filename tests: sport suffix appended correctly, unsafe characters sanitized.

@cagnulein cagnulein added this to the 2.21 milestone May 27, 2026
cagnulein and others added 28 commits May 27, 2026 11:29
…e-Parsing-Issue-CORE-Sensor-Garmin-Sync-Failure
…e-Parsing-Issue-CORE-Sensor-Garmin-Sync-Failure
…e-Parsing-Issue-CORE-Sensor-Garmin-Sync-Failure
Automatic update of translatable strings extracted from source code.
Updated 30 language files in src/translations/

- Updated by GitHub Actions (Testing Mode)
- Triggered by: pull_request
- Date: 2026-06-08 09:42:55 UTC
…ue-CORE-Sensor-Garmin-Sync-Failure' of https://github.com/cagnulein/qdomyos-zwift into Detailed-Bug-Report-Running-Workout-Incline-Parsing-Issue-CORE-Sensor-Garmin-Sync-Failure
* Handle SmartBike manual resistance power table

* Route SmartBike workout targets through custom table

* Apply cadence scaling to custom resistance watts

* Keep SmartBike workout targets manual-only

* Narrow SmartBike target resistance handling

* cleaning code
On Windows with MSVC/MinGW, qmake places compiled .qm files in
translations/debug/ (for debug builds), but translations.qrc
references them at translations/xxx.qm. This causes NMAKE to fail
with U1073: "don't know how to make translations\qdomyos-zwift_vi.qm".

Add explicit `lrelease src/qdomyos-zwift.pri` before qmake in all
Windows CI build steps, mirroring the same approach already used for
Linux and Android builds.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Automatic update of translatable strings extracted from source code.
Updated 30 language files in src/translations/

- Updated by GitHub Actions (Testing Mode)
- Triggered by: pull_request
- Date: 2026-06-09 11:51:08 UTC
@cagnulein
cagnulein merged commit 709fa3e into master Jun 9, 2026
@cagnulein
cagnulein deleted the Detailed-Bug-Report-Running-Workout-Incline-Parsing-Issue-CORE-Sensor-Garmin-Sync-Failure branch June 9, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant