Fix 'Other folders' button inaccessible in landscape mode (#3769) - #4751
Closed
cagnulein wants to merge 1 commit into
Closed
Fix 'Other folders' button inaccessible in landscape mode (#3769)#4751cagnulein wants to merge 1 commit into
cagnulein wants to merge 1 commit into
Conversation
In Qt Quick layouts, mixing anchors.fill/anchors.bottom with Layout.* properties in children of ColumnLayout/RowLayout causes undefined behavior: the anchored item overrides layout-managed geometry, pushing the bottom button off screen in landscape orientation. Fix TrainingProgramsList.qml and GPXList.qml by replacing anchor-based positioning with proper Layout.fill*/Layout.preferredHeight properties on all children of the root ColumnLayout. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
cagnulein
added a commit
that referenced
this pull request
Jun 30, 2026
Screenshots belong in PR comments, not the repository. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
Author
|
Closing this PR — the GPXList.qml and TrainingProgramsList.qml layout fixes are already included in PR #4752 (branch |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3769 — the "Other folders" button was pushed off-screen and inaccessible when the device was in landscape orientation.
Root cause: In Qt Quick, children of
ColumnLayout/RowLayoutmust useLayout.*properties for sizing. Whenanchors.fill: parentoranchors.bottom: parent.bottomare used instead, the anchor geometry overrides the layout engine's measurements, causing the content area to expand and bottom buttons to be clipped or pushed off-screen in landscape.Files fixed:
src/GPXList.qml— used on Android/iOS (GPX route list, "Other folders" button)src/TrainingProgramsList.qml— used on desktop (training program list, all 3 bottom buttons)Changes:
anchors.fill: parent/anchors.top: parent.topwithLayout.fillWidth: true+Layout.fillHeight: trueon the contentRowLayoutanchors.fill: parentwithLayout.fillHeight: trueon the innerColumnLayoutLayout.preferredHeight: parent.heightwithLayout.fillHeight: trueonListViewandScrollViewheight: 50; width: parent.width; anchors { bottom: parent.bottom }withLayout.fillWidth: true; Layout.preferredHeight: 50on bottom buttonsScreenshots (tablet 2560×1600, all 4 rotations)
GPXList — Landscape (0°)
GPXList — Portrait (90°)
GPXList — Landscape Inverted (180°)
GPXList — Portrait Inverted (270°)
TrainingProgramsList — Landscape (from tablet, JS variant used on Android)
Test plan
🤖 Generated with Claude Code