Improve map screen UX: toggle button, title fix, configurable data overlay - #4797
Open
cagnulein wants to merge 2 commits into
Open
Improve map screen UX: toggle button, title fix, configurable data overlay#4797cagnulein wants to merge 2 commits into
cagnulein wants to merge 2 commits into
Conversation
… data overlay Reported by Maksim Savrilov via email testing feedback: - The map icon now acts as a toggle (tap to open, tap again to close and return to tiles) instead of relying on the shared back/drawer button, which was confusing. - Fixed the toolbar title overlapping the map icon on narrow screens. - Removed the dead "Close" button in GoogleMap.qml (never wired to the toggle signal, and effectively unreachable behind the WebView layer). - Added per-metric visibility settings for the resizable data box shown on the map screen (Speed, Cadence, HR, Calories, Odometer, Watt, Elapsed, Inclination, Resistance, Altitude, Elevation), so users can show only the metrics they care about instead of always seeing all 11. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Drop the new map_metric_*_enabled settings and wire the map's data box visibility to the same tile_*_enabled switches already used by the main tiles grid (Settings -> Tiles), avoiding a duplicate parallel settings group for the same concept. There is no dedicated "altitude" tile, so that line follows the elevation tile switch instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Based on testing feedback from Maksim Savrilov (thread "HR zones tile and graph, disussion"):
GoogleMap.qml— it was never actually wired to close the map (thepopupclosesignal had no listener), and would likely have been hidden behind the WebView layer on mobile anyway.tile_speed_enabled,tile_cadence_enabled,tile_heart_enabled,tile_calories_enabled,tile_odometer_enabled,tile_watt_enabled,tile_elapsed_enabled,tile_inclination_enabled,tile_resistance_enabled,tile_elevation_enabled(also used for the Altitude line, since there's no dedicated altitude tile). No new settings were introduced. The box itself was already resizable (drag the bottom-right handle) with auto-fitting font size.Test plan
🤖 Generated with Claude Code