fix: iConsole+ as FTMS bike has no ERG support - #4820
Merged
Conversation
When iConsole+ is configured as FTMS bike (toorx_ftms=true), set resistance_lvl_mode=true and ergModeSupported=false since these devices don't natively support power-based ERG control. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
User confirmed the Toorx SRX Evolve (iConsole+) has 24 resistance levels. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iConsole+and is configured as an FTMS bike via thetoorx_ftmssetting, the device was incorrectly defaulting toergModeSupported=truedeviceDiscoveredcase to setresistance_lvl_mode=true,ergModeSupported=false, andmax_resistance=16for iConsole+ FTMS bikesTest plan
toorx_ftms=true🤖 Generated with Claude Code