Use accumulated TRIMP for FIT training effect - #4847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This changes the FIT aerobic
total_training_effectestimate to prefer the accumulated TRIMP load thatqfitalready calculates, instead of using only a duration-normalized HR zone average.Why
The previous zone-average formula made steady aerobic workouts look too low because the value barely increased with workout duration. Garmin describes Training Effect as accumulating during an activity, so using the already accumulated TRIMP value gives a more Garmin-like progression while keeping the existing zone-average fallback.
For the analyzed 30-minute indoor cycling sample, the current code produced about
0.8; the TRIMP-based mapping produces about1.88, which is a more plausible minor/near-maintaining aerobic effect for a steady Z2 session.Validation
git diff --check42.5388maps to aerobic TE1.883No full build was run for this one-line calculation change.