Fix MOK Fitness S10 Ultra resistance control (use 0xFFF2 instead of FTMS control point) - #4853
Merged
Merged
Conversation
… of FTMS control point The bike NAKs FTMS_SET_TARGET_RESISTANCE_LEVEL sent over the standard FTMS control point (0x2AD9), so auto-resistance never took effect. Its own app writes resistance changes as a single raw command (AF 05 04 <level> AA) to a proprietary characteristic (0xFFF2) instead, confirmed via BLE packet capture and NRF Connect testing (reported in #4844).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FTMS_SET_TARGET_RESISTANCE_LEVELsent over the standard FTMS control point (0x2AD9).0xFFF2) with the formatAF 05 04 <level> AA, no handshake required.ftmsbike::forceResistance()now detectsMOK_FITNESSand writes that raw command directly to0xFFF2instead of going through the FTMS control point; the characteristic/service are discovered and cached duringstateChanged()alongside the existing FTMS/Zwift Play discovery.Test plan
forceResistance/service-discovery patterns used for similar non-FTMS-control-point bikes (e.g.SL010,SPORT01).Generated by Claude Code