Fix floating window metric settings not persisting - #4872
Merged
Conversation
onSetSettings() only applied an incoming value when its QVariant type exactly matched the type already stored in QSettings. QSettings backends (e.g. Android/INI) don't reliably round-trip bool, so a stored setting could come back as QString/int, causing the type check to fail and the new value to be silently discarded and echoed back unchanged. Coerce the incoming value to the stored type instead of dropping it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TemplateInfoSenderBuilder::onSetSettings(src/templateinfosenderbuilder.cpp) only wrote an incoming setting toQSettingswhen itsQVarianttype exactly matched the type already stored. QSettings backends (INI on desktop, native storage on Android) don't reliably round-tripbool, so a previously-saved value can come back asQString/int. When that happened, the type check failed and the new value was silently discarded, with the old value echoed back as if nothing changed.QVariant::convert) instead of dropping it when types differ but are convertible, then always persist.Test plan
Generated by Claude Code