Support 13-character CARE Sports Plus bikes - #4878
Draft
cagnulein wants to merge 2 commits into
Draft
Conversation
cagnulein
marked this pull request as ready for review
August 3, 2026 10:36
Owner
Author
|
Follow-up detection hardening: the generic CARE rower branch now explicitly excludes |
cagnulein
marked this pull request as draft
August 3, 2026 10:41
cagnulein
force-pushed
the
codex/care-sportsplus-bike-parser
branch
from
August 3, 2026 10:58
1de6cc0 to
850e38d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for the 13-character CARE Sports Plus bike identified in the user-provided log as
CARE113770737.The detection rule is intentionally specific:
CAREprefix1This routes
CARE113770737tosportsplusbikewhile preserving the existing CARE device classifications.Analysis
Device-name classification
A 13-character name alone is not sufficient:
CARE113770737: 13 characters, suffix starts with1→ bikeCARE10692135: 12 characters → known Sports Plus rowerCARE968300122: 13 characters, but suffix starts with9→ known rowerCARE9040177: 11 characters → existing legacy Care bike detectionThis avoids broadening the existing rower rule (
CAREnames with length >= 12) to the user's bike.GitHub protocol references
The analysis was cross-checked against the existing CARE reports:
User-provided log analysis
The current log contains:
20 1020 0020 0140 00 9a 56 30The frame parser validates:
20 10or20 0020 10framesThe byte-10 watt decoding matches the watt value printed in the log for 1,799 correlated telemetry frames. Speed uses the same cadence-to-speed coefficient already used by the Sports Plus rower parser.
Implementation
sportsplusbike.CARE113770737in the device detection test data.Validation
git diff --check: passed.sportsplusbike.cpp: compiled successfully with the existing Qt 5.15.2 MinGW build.bluetooth.cpp: compiled successfully.TestSportsPlusBikeParser.cpp: compiled successfully.The complete test-suite executable was not linked because the local temporary reconstruction of the pre-existing static application library has unrelated unresolved application/moc dependencies.
The outgoing
20 01resistance command was not changed in this PR. Its effect on the bike's physical resistance still requires validation with the real Care Cardio Liner IX.