Ensure build-variant workflow patches C++ defaults to match QML settings - #4910
Merged
cagnulein merged 1 commit intoAug 11, 2026
Merged
Conversation
cagnulein
deleted the
codex/fix-default-value-synchronization-for-settings
branch
August 11, 2026 11:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
src/settings.qmldefaults for some build variants which caused a runtime mismatch with the C++ fallbackQZSettings::default_*values and required users to save settings manually before the C++ code used the intended value.Description
sedQML-only replacement in.github/workflows/main.ymlwith a small Python snippet that patches bothsrc/settings.qml(theproperty string ...) andsrc/qzsettings.cpp(theconst QString QZSettings::default_...) to the samematrix.variantvalue for each variant.Testing
nordictrack_2950_ip,tdf_10_ip,proform_elliptical_ip,proform_rower_ip) against temporary copies and verified bothsettings.qmlandqzsettings.cppcontained the expected"localhost"variant default, and these simulations passed..github/workflows/main.ymlas YAML and rangit diff --checkwhich reported no problems;actionlintwas not installed in the environment used for verification.Codex Task