Add support for XCX bike (proprietary FFF6 telemetry) with parser, device integration and tests - #4912
Closed
cagnulein wants to merge 1 commit into
Closed
Add support for XCX bike (proprietary FFF6 telemetry) with parser, device integration and tests#4912cagnulein wants to merge 1 commit into
cagnulein wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
xcxbikedevice implementation withxcxbike.handxcxbike.cppthat parses proprietary FFF6 telemetry and exposes metrics via the existingbikeinterface.xcxbike::parseTelemetryto decode the captured 20-byte telemetry frame and update speed, cadence, power, distance, resistance and related state.bluetooth::deviceDiscoveredso devices whose name starts with"XCX-"are instantiated asxcxbikebefore falling back to generic FTMS handling.bluetooth.h, updateqdomyos-zwift.prito compile the new sources/headers, and register the device in the test device indices.tst/Devices/TestXcxBikeParser{.h,.cpp}validate decoding of captured packets, and include the test in the test projecttst/qdomyos-zwift-tests.pro.Testing
qdomyos-zwiftbuild) which completed successfully.TestXcxBikeParserwhich executed theparseTelemetrycases and all assertions passed.qdomyos-zwift-testswhich completed with the updated device index and new tests included (tests passed).Codex Task