Gate KICKR gear and inclination commands on device ACK - #4917
Draft
cagnulein wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The BLE
characteristicWrittencallback only confirms that the local BLE stack accepted the write. KICKR logs show the trainer later sends a command response on the Wahoo characteristic:A captured log measured 16
setSimGraderesponses with an average latency of approximately 537 ms (min 278 ms, max 841 ms). Sending commands on local write completion can therefore queue intermediate grades/gears inside the trainer.Implementation
setSimGradeandsetWheelCircumferencewrites wait for the matching Wahoo response opcode.Validation
git diff --checkqmakeis unavailable.