Add device-command mapping for treadmill inclination overrides and preserve logical selection on lossy feedback - #4947
Open
cagnulein wants to merge 2 commits into
Conversation
Owner
Author
|
Alexandra Cambri Acezoe P30 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
treadmillInclinationDeviceCommand,treadmillInclinationOverrideForRawFeedback, and updatestreadmillInclinationOverrideReverseto return device-command values when configured, and to remember/apply logical selections while awaiting/validating feedback.treadmill(m_mappedInclination*) to track mapped rows, awaiting feedback and the last reported raw value, and addsparseInclinationOverrideto use new feedback-aware mapping.treadmill_inclination_override_device_command_*inqzsettings.h/cpp, increments settings counts, and exposes them in the UI by updatingsettings-treadmill-inclination-override.qml,settings.qmlandsettings-catalog.json(new controls and a repeater for raw rows).treadmillInclinationOverrideForRawFeedback/parseInclinationOverride) and adds unit tests (TreadmillInclinationOverrideTest) and test wiring to validate mapping and feedback behavior.Testing
tst/Devices/TestTreadmillInclinationOverrides.cppand header, and registered them in the test project file; test suite exercises legacy reverse mapping, custom device-command mappings, and feedback preservation logic.TreadmillInclinationOverrideTestand the updated tests under the test harness; the new tests passed.Codex Task