Settings refactor: modern UI default with persistence and behavior parity - #4948
Draft
cagnulein wants to merge 54 commits into
Draft
Settings refactor: modern UI default with persistence and behavior parity#4948cagnulein wants to merge 54 commits into
cagnulein wants to merge 54 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors QZ settings around the existing persistent
Settings {}ABI while making the catalog-driven modern settings UI the default. The legacy renderer remains available as a temporary fallback until runtime smoke testing is complete.Persistence safety
Complete settings catalog
visible: falserestartRequiredmetadataShared behavior parity
The modern UI and catalog search use the shared
settingsBehaviorcontroller. It now preserves known legacy behavior that is more complex than a direct assignment, including:Modern settings UI
Validation
Permanent CI checks cover:
The remaining gate before deleting the legacy renderer is manual visual/interaction smoke testing on iOS and at least one non-iOS platform, plus any dynamic visibility/enabled issues exposed by that testing.