Skip to content

Timer stop & start functions fix#1154

Open
wiklam wants to merge 7 commits intocahirwpz:masterfrom
wiklam:fix-timers
Open

Timer stop & start functions fix#1154
wiklam wants to merge 7 commits intocahirwpz:masterfrom
wiklam:fix-timers

Conversation

@wiklam
Copy link
Copy Markdown
Collaborator

@wiklam wiklam commented Jun 14, 2021

We want to set up the interrupts while attaching a timer and eventually stop it from invoking interrupts.
Removing unnecessary function tm_select (choosing time source is done while setting up timers in clock.c).
Typo in rtc.c.

@wiklam wiklam added the review please review this PR label Jun 14, 2021
@cahirwpz
Copy link
Copy Markdown
Owner

cahirwpz commented Sep 3, 2021

IIRC The intent of this PR is to change timer drivers so that resource allocation (including interrupt handler registration) is performed only when the driver is attached. This involves masking and unmasking an interrupt in *_start and *_stop timer routines. There's no infrastructure that allows for a single intr_handler_t to be temporarily disabled without tearing it down. Hence we resort to configuring timers in such a way they're effectively disabled. Is that correct?

@cahirwpz cahirwpz removed the review please review this PR label Jun 20, 2022
@cahirwpz cahirwpz added the orphaned needs new owner label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

orphaned needs new owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants