Ready for review. #34
Conversation
caidobot
temporarily deployed
to
AP-Workflows - doc-developer PR #34
Render
Destroyed
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 31.6%, saving 74.00 KB.
27 images did not require optimisation. |
caidobot
temporarily deployed
to
AP-Workflows - doc-developer PR #34
Render
Destroyed
Sytten
left a comment
Sytten
left a comment
There was a problem hiding this comment.
Good first pass. Though this documentation should live in the main doc, not the developer doc. Lets switch repo :)
| ::: | ||
|
|
||
| ``` rust | ||
| pub enum NodeDataProp { |
There was a problem hiding this comment.
Lets not dump a rust enum here, most of that data is unnecessary and hard to read for users.
This was mostly a reference for you to craft the documentation around it.
| } | ||
| ``` | ||
|
|
||
| With this typed data system, even though Nodes are processed sequentially, you do not need a direct line between two Nodes in order to pass data from one to another. |
There was a problem hiding this comment.
We use the alias system for that. Unsure if we explained it elsewhere, but this is the place to write about it.
So [node_alias].[output_alias] is the format we use.
| ::: | ||
|
|
||
| ``` rust | ||
| pub enum NodeDataProp { |
There was a problem hiding this comment.
Same comment as for concept, we dont want to just dump a rust enum here. We want a real reference.
Also what is more important here is the automatic conversion between types which is not present.
No description provided.