Move date humanization to client-side JavaScript#3419
Open
SK-Sathyavada-008 wants to merge 1 commit into
Open
Conversation
Fixes cake-build#1476 - Dates were being humanized at build time using C# Humanizer, causing them to become stale immediately after deployment. This change moves the humanization to client-side JavaScript using a data-timestamp attribute, so dates like 'Last updated 3 months ago' are always accurate for every visitor.
Author
|
Hi, I submitted a PR for this issue : #3419 |
Author
|
@microsoft-github-policy-service agree
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1476
Problem
Dates like "Last updated 3 months ago" were computed at build time using
C# Humanizer, causing them to become stale immediately after deployment.
Solution
DateHumanizeExtensions.Humanize()calls with adata-timestampattribute containing the Unix timestamp in millisecondshumanize-dates.js— a small vanilla JS file that computes therelative date live in the visitor's browser
@using Humanizer;imports from both template files