Skip to content

CW 882: Integrate Seed Verification Flow To Integration Tests #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 51 commits into
base: main
Choose a base branch
from

Conversation

Blazebrain
Copy link
Contributor

Issue Number (if Applicable): Fixes #

Description

Please include a summary of the changes and which issue is fixed / feature is added.

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods

Comment on lines 171 to 179
//* ======Confirm it displays the properly formatted title===========
final transactionType = dashboardViewModel.getTransactionType(item.transaction);

final title = item.formattedTitle + item.formattedStatus + transactionType;

commonTestCases.findWidgetViaDescendant(
of: find.byKey(ValueKey(keyId)),
matching: find.text(title),
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this was removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to add a TODO there, there's been some inconsistencies with the wordings for the title, something from the flutter end as it doesn't constantly happen. Happens once, and when you rerun, it doesn't happen again. I think I mentioned earlier on one of the calls.

MrCyjaneK and others added 25 commits February 12, 2025 18:03
fix tests not working in latest main
…Integrate-Seed-Verification-Flow-To-Integration-Tests
…Integrate-Seed-Verification-Flow-To-Integration-Tests
…Integrate-Seed-Verification-Flow-To-Integration-Tests
…Integrate-Seed-Verification-Flow-To-Integration-Tests
…Integrate-Seed-Verification-Flow-To-Integration-Tests
…Integrate-Seed-Verification-Flow-To-Integration-Tests
- Pause screenshots for now, results in a super large json response file
- Fix delay on send bottomsheet because of pumpAndSettle animation
- Fix issue with integration test runner script
…Integrate-Seed-Verification-Flow-To-Integration-Tests
…Integrate-Seed-Verification-Flow-To-Integration-Tests
…Integrate-Seed-Verification-Flow-To-Integration-Tests
…tests.

This change:
- Handles the slider during the send confirmation flow during the send integration test
- Adds the missing seeds for the restore flow to the relevant workflow files
Copy link
Contributor

@OmarHatem28 OmarHatem28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and they failed on my local testing

Comment on lines +33 to +36
/// For bitcoin/Monero/Wownero WalletTypes.
await commonTestFlows.welcomePageToRestoreWalletThroughSeedsFlow(
WalletType.solana,
secrets.solanaTestWalletSeeds,
WalletType.bitcoin,
secrets.bitcoinTestWalletSeeds,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this only covers bitcoin

Comment on lines +52 to +56
/// For Solana/Tron WalletTypes.
await dashboardPageRobot.navigateToWalletsListPage();

await commonTestFlows.restoreWalletFromWalletMenu(
WalletType.bitcoin,
secrets.bitcoinTestWalletSeeds,
WalletType.solana,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, it only covers solana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants