-
Notifications
You must be signed in to change notification settings - Fork 229
CW 882: Integrate Seed Verification Flow To Integration Tests #1966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CW 882: Integrate Seed Verification Flow To Integration Tests #1966
Conversation
…Integrate-Seed-Verification-Flow-To-Integration-Tests
… test script to add a watch dog to prevent infinite running on CI
https://github.com/cake-tech/cake_wallet into Integrate-Seed-Verification-Flow-To-Integration-Tests
… and resulting errors
//* ======Confirm it displays the properly formatted title=========== | ||
final transactionType = dashboardViewModel.getTransactionType(item.transaction); | ||
|
||
final title = item.formattedTitle + item.formattedStatus + transactionType; | ||
|
||
commonTestCases.findWidgetViaDescendant( | ||
of: find.byKey(ValueKey(keyId)), | ||
matching: find.text(title), | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this was removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot to add a TODO there, there's been some inconsistencies with the wordings for the title, something from the flutter end as it doesn't constantly happen. Happens once, and when you rerun, it doesn't happen again. I think I mentioned earlier on one of the calls.
…Integrate-Seed-Verification-Flow-To-Integration-Tests
# Conflicts: # lib/src/screens/wallet_keys/wallet_keys_page.dart
fix tests not working in latest main
…Integrate-Seed-Verification-Flow-To-Integration-Tests
https://github.com/cake-tech/cake_wallet into Integrate-Seed-Verification-Flow-To-Integration-Tests
…Integrate-Seed-Verification-Flow-To-Integration-Tests
…Integrate-Seed-Verification-Flow-To-Integration-Tests
…Integrate-Seed-Verification-Flow-To-Integration-Tests
…Integrate-Seed-Verification-Flow-To-Integration-Tests
…Integrate-Seed-Verification-Flow-To-Integration-Tests
…Integrate-Seed-Verification-Flow-To-Integration-Tests
…Integrate-Seed-Verification-Flow-To-Integration-Tests
…Integrate-Seed-Verification-Flow-To-Integration-Tests
https://github.com/cake-tech/cake_wallet into Integrate-Seed-Verification-Flow-To-Integration-Tests
…tests. This change: - Handles the slider during the send confirmation flow during the send integration test - Adds the missing seeds for the restore flow to the relevant workflow files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and they failed on my local testing
/// For bitcoin/Monero/Wownero WalletTypes. | ||
await commonTestFlows.welcomePageToRestoreWalletThroughSeedsFlow( | ||
WalletType.solana, | ||
secrets.solanaTestWalletSeeds, | ||
WalletType.bitcoin, | ||
secrets.bitcoinTestWalletSeeds, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this only covers bitcoin
/// For Solana/Tron WalletTypes. | ||
await dashboardPageRobot.navigateToWalletsListPage(); | ||
|
||
await commonTestFlows.restoreWalletFromWalletMenu( | ||
WalletType.bitcoin, | ||
secrets.bitcoinTestWalletSeeds, | ||
WalletType.solana, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, it only covers solana
Issue Number (if Applicable): Fixes #
Description
Please include a summary of the changes and which issue is fixed / feature is added.
Pull Request - Checklist