[DNM] ui: show EUR offers for SEPA currencies on onramping screen #2180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarHatem28
requested changes
Apr 11, 2025
Comment on lines
152
to
157
| // final hasSelectedQuote = selectedQuote != null; | ||
| final hasSelectedPaymentMethod = selectedPaymentMethod != null; | ||
| final isPaymentMethodLoaded = paymentMethodState is PaymentMethodLoaded; | ||
| final isBuySellQuotLoaded = buySellQuotState is BuySellQuotLoaded; | ||
|
|
||
| return hasSelectedQuote && | ||
| hasSelectedPaymentMethod && | ||
| return hasSelectedPaymentMethod && |
Contributor
There was a problem hiding this comment.
why this change? it shouldn't be ready until the user selects a quote
Collaborator
Author
There was a problem hiding this comment.
With this change we do not have any details regarding the quote because we don't select the quote by default from EUR-only providers (if the currency is SEPA enabled), as this would be unreliable. We just do not calculate anything in terms of price because
- provider cannot give use price in local currency
- we cannot calculate the price on our own because we do not include SEPA fees and provider fees, so using for example priceapi wouldn't work.
Yet we still need to mark the trade as ready to allow the user to click the button - so if there is any quote (even in foreign currency) we unlock the button
OmarHatem28
reviewed
Apr 11, 2025
MrCyjaneK
changed the title
Contributor
|
@MrCyjaneK what's the state of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and which issue is fixed / feature is added.
Pull Request - Checklist