New themes #2239
Merged
New themes #2239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into new-themes
Foundation, Theme Data Refactor, and First Extension Cleanup Batch. This commit completes the first major phase of migrating to Material 3 theming by setting up the foundations for material 3 integration and begins the initial migration, removing custom theme extensions, updating theme data, and refactoring all relevant widget and page theming to use Material 3’s built-in color and typography tokens. These changes: - Lays the groundwork for Material 3 theming by restructuring the app’s theme configuration to use Material 3’s ColorScheme and TextTheme as the primary sources of color and typography throughout the app. - Refactors the core theme config files by removing legacy custom color roles ensuring all color definitions now map directly to Material 3’s role. - Begins the first batch migration of custom theme extensions (InfoTheme, PlaceholderTheme, KeyboardTheme, PinCodeTheme) and updates all affected widgets and pages to use Material 3 color and typography tokens instead of the custom properties. - Cleans up the codebase by deleting the files of the initial set of migrated extensions and eliminating all related imports and usages.
This change: - Updates the themes README.md file to reflect the current structure and give more information based on the first major phase that was completed.
Deleting previous theme extensions
Another batch of migrations from existing extensions
Third Migration batch for theme extensions
Final Migration batch for previous theme extensions
This change: - Adds new set of hero images - Modifies the core structure for the themes - Add missing color tokens to the theme classes - Adds a CustomThemeColor class for custom color tokens - Modifies the themelist to have a fall back for previous theme implementation - Adds localization for some texts - Modifies the flow for loading the theme on app start - Add a WidgetsBindingObserver that listens for changes in the device theme and updates the app theme when there is a change - Registers the themeStore as a Singleton for codebase wide use
This change: - Migrates UI flows across the app to the new themes - Confirms styling and typography of components across the app uses the new themes - Remove instances of Palette use - Switch TextStyles across the app to use theme text styles
This change: - Syncs and fixes conflicts - Cleans up duplicate text and localizations
This change: - Adjusts bottomsheets styling and removes duplicate close button - Removes more themedata extensions from the previous implementation
- Update menu colors - Update padding/divider size for cards
- Fix navigation dock shadow - Update wallet screen colors
This change: - Adds gradient backgrounds to the dashbaord and balance cards. - Migrates the input fields across the app to BaseTextFormFields. - Removes dependence of input fields on individual styling, focusing instead on using theme defined InputDecoration styling with adjustments on individual components where needed. - Applies new theme styling to BaseTextFormField, AddressTextField and CurrencyAmountTextField.
- Fix nagivation_dock shadow - Minor fixes
This change: - Adds a fallback to CurrencyAmountTextField, AddressTextField, and BaseTextFormField, allowing them use the previous theme styling. - Adds localization for new texts
…into new-themes
OmarHatem28
reviewed
May 24, 2025
Comment on lines
67
to
68
| // TODO: remove this once the theme is tested | ||
| await store.themeStore.setTheme(store.themeStore.currentTheme); |
There was a problem hiding this comment.
is this TODO still valid?
…the user previous theme preference is used.
…components to new theme styling.
This change: - Refactors theme loading logic to handle backup restore edgecase - Refreshes the theme based on the user saved preference during restore from backup flow
Test new icons for navigation_dock.dart
Fix swap icon clipping Fix some text colors Add more hero images
Fix info box CTA colors Fix sync indicator colors
Update dark theme colors (minor) Update crypto_balance_widget.dart icon
Fix some colors
This change: - Fixes issue with themeMode resetting to system mode when app is restarted causing a UI glitch - Updates theme checks from `currentTheme.type == ThemeType.dark` to `currentTheme.isDark` for consistency - Adjusts UI components to use the theme directly from the themeStore
OmarHatem28
reviewed
May 25, 2025
There was a problem hiding this comment.
can be updated later to just make a helper function that decide which pageRoute to use and just call this function with the page as the parameter
OmarHatem28
approved these changes
May 25, 2025
There was a problem hiding this comment.
just the comment left above, @Blazebrain please handle it in a separate branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number (if Applicable): Fixes #
Description
This PR revamps Cake Wallet’s theming system by migrating from a custom theme extension based approach to a fully Material 3 (M3) compliant theming system. The goal is to simplify maintenance, improve consistency, and leverage Flutter’s built‑in Material 3 color tokens and patterns.
Please include a summary of the changes and which issue is fixed / feature is added.
Pull Request - Checklist