-
Notifications
You must be signed in to change notification settings - Fork 106
Deprecate identifier collection approach. #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.x
Are you sure you want to change the base?
Conversation
|
||
$service->loadIdentifier('Authentication.Password'); | ||
$service->loadAuthenticator('Authentication.Session', [ | ||
'identifier' => 'Authentication.Password', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we also support identifier
being an object? If we're going to change how authentication is wired up, we could make it more compatible with the DI container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already done, afaik there is a test case added
https://github.com/cakephp/authentication/pull/712/files#diff-b9a4b24bdb898b49129cd5b64f3b2f3cf9e71da882e8f07dc277d3df0d96394fR143
Co-authored-by: Mark Story <[email protected]>
Added also a test for a direct IdentifierCollection passed: |
There's |
Good point. |
Refs #710
The config has to be only slightly adjusted to be "safer".
Seems BC and easy to switch up.