Skip to content

Deprecate identifier collection approach. #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: 3.x
Choose a base branch
from

Conversation

dereuromark
Copy link
Member

Refs #710

The config has to be only slightly adjusted to be "safer".
Seems BC and easy to switch up.

@dereuromark dereuromark added this to the 3.next milestone Apr 20, 2025
@dereuromark dereuromark marked this pull request as ready for review April 20, 2025 11:33

$service->loadIdentifier('Authentication.Password');
$service->loadAuthenticator('Authentication.Session', [
'identifier' => 'Authentication.Password',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we also support identifier being an object? If we're going to change how authentication is wired up, we could make it more compatible with the DI container.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dereuromark
Copy link
Member Author

Added also a test for a direct IdentifierCollection passed:
f2c713e
Or is that also deprecated? I guess it can be useful in some rare cases.

@dereuromark dereuromark mentioned this pull request Apr 20, 2025
3 tasks
@ADmad
Copy link
Member

ADmad commented Apr 22, 2025

There's AuthenticationService::getIdentificationProvider() which returns the identifier instance which successfully returned the identity. So that method needs to be updated too to get the identifier instance from the successful authenticator (if the IdentifierCollection::getIdentificationProvider() instance for the AuthenticationServices returns null).

@dereuromark
Copy link
Member Author

Good point.
Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants