Feat/expose process info#6
Open
halfcrazy wants to merge 2 commits into
Open
Conversation
cakturk
reviewed
Jan 17, 2020
cakturk
left a comment
cakturk
left a comment
Owner
There was a problem hiding this comment.
BTW, it would be better to introduce go module support in a separate commit.
| name string | ||
| Pid int | ||
| Name string | ||
| } |
Owner
There was a problem hiding this comment.
It makes sense, a few people already asked me to export these fields.
| if err != nil { | ||
| return nil, err | ||
| } | ||
| binary.LittleEndian.PutUint32(ip[i:j], uint32(u)) |
| } | ||
| n, err := stat.Read(buf[:]) | ||
| stat.Close() | ||
| if err != nil { |
Owner
There was a problem hiding this comment.
This is wrong. You don't need to check for nil there. os.Open always returns non-nil
value if it succeeded. Check the source code for os.Open.
| } | ||
| if f != nil { | ||
| defer f.Close() | ||
| } |
Owner
There was a problem hiding this comment.
Here, again, the same situation as above. Nil-check is unnecessary here as the
os.Open already succeeded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.