-
Notifications
You must be signed in to change notification settings - Fork 17
Support Custom EKS Nodegroup AMI Images #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Ronard <[email protected]>
Co-authored-by: Ronard <[email protected]>
Co-authored-by: Ronard <[email protected]>
…re backward compatibility Co-authored-by: Ronard <[email protected]>
Co-authored-by: Ronard <[email protected]>
ronardcaktus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once precommit's getCacheEntry is back, looks good to merge
🦕🦖
Co-authored-by: Ronard <[email protected]>
copelco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Added a few small suggestions
| ========== | ||
|
|
||
| `X.Y.Z`_ (TBD-DD-DD) | ||
| `2.4.0`_ (2025-09-08) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we need to add a link for this (and 2.3.0) at the bottom of the file:
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index a8120a0..a40c256 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -257,7 +263,8 @@ Backwards-incompatible changes:
* Initial public release
-
+.. _2.4.0: https://aws-web-stacks.s3.amazonaws.com/index.html?prefix=2.4.0/
+.. _2.3.0: https://aws-web-stacks.s3.amazonaws.com/index.html?prefix=2.3.0/
.. _2.2.0: https://aws-web-stacks.s3.amazonaws.com/index.html?prefix=2.2.0/
.. _2.1.2: https://aws-web-stacks.s3.amazonaws.com/index.html?prefix=2.1.2/
.. _2.1.1: https://aws-web-stacks.s3.amazonaws.com/index.html?prefix=2.1.1/| * **Custom AMI Support**: | ||
| * Added support for conditionally specifying custom AMIs for EKS node groups. | ||
| * New parameters: | ||
| - ``CustomAMIImageType``: Corresponding image type (e.g., ``AL2023_x86_64_STANDARD``, ``AL2_x86_64``). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the nested lists to render properly for me, I had to add a few newlines:
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index a8120a0..74fcff7 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -8,24 +8,30 @@ Change Log
* EBS volume type for worker nodes has been changed from ``gp2`` to ``gp3``. This will result in node replacement. Workload migration should still be managed by AWS.
-**What's new in 2.4.0:**
+**What's new in 2.4.0 (#119):**
* **Custom AMI Support**:
+
* Added support for conditionally specifying custom AMIs for EKS node groups.
* New parameters:
+
- ``CustomAMIImageType``: Corresponding image type (e.g., ``AL2023_x86_64_STANDARD``, ``AL2_x86_64``).
- ``CustomEKSAMI``: AMI ID to use for worker nodes. If ``CustomAMIImageType`` is set, one isn't required to set ``CustomEKSAMI``.
+
* Conditional logic ensures that these settings are only applied when explicitly provided.
* **Cluster Version Parameterization**:
+
* Introduced ``EksClusterVersion`` parameter to allow template users to control the Kubernetes version.
* If this parameter is not set, AWS will default to the version already in place.
* **Launch Template Enhancements**:
+
* Node group now uses a versioned launch template reference. This will support inplace changes rather than entire nodegroup replacement where possible.
* Custom AMI ID is injected into the launch template conditionally, based on user input.
* **EBS Improvements**:
+
* Changed block storage type from ``gp2`` to ``gp3`` in the launch template for better performance and cost optimization.I tested locally with pip install restview and restview CHANGELOG.rst
Co-authored-by: Colin Copeland <[email protected]>
Co-authored-by: Colin Copeland <[email protected]>
Co-authored-by: Colin Copeland <[email protected]>
0a807a2 to
1be9b48
Compare
As part of the EKS cluster upgrade support from 1.32 to 1.33.
https://app.clickup.com/t/868fckhdk