[WIP] Adding initial changes to drop simulations that don't have a full set… #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of WL data to return for a given WL
claalmve
commented
Apr 18, 2025
climakitae/util/warming_levels.py
Outdated
| sims_to_drop = warming_data.all_sims.where(is_null_sim_mask, drop=True) | ||
|
|
||
| if len(sims_to_drop.all_sims.values) > 1: | ||
| print(f"These are the following simulations and their given SSPs to be dropped since they do not reach return a full set of WL data for this given WL: {sims_to_drop.all_sims.values}") |
There was a problem hiding this comment.
Add WL number in print statement, in case this call creates a DataArray across multiple warming levels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… of WL data to return for a given WL
Summary of changes and related issue
[What's changed in this PR?]
Relevant motivation and context
[Why did you change this and what applicable context is needed to understand why this change is needed?]
How to test
[How should reviewers test the changes?]
Type of change
To-Do
_before the name