Units tests for data_load.py

[acordonez]

Summary of changes and related issue

Add more unit tests for core.data_load.py to get coverage up to 83%. Add type hints to data_load.py.

Relevant motivation and context

We want to increase test coverage to at least 80%.

No tests written for read_catalog_from_csv(), which is unused and will be removed.

How to test

pip install pytest-cov
pytest tests/data_load/ --cov=climakitae.core.data_load --cov-report term-missing

These tests have taken ~7 minutes to complete for me locally. Many of the tests are loading and checking real datasets.

I ran the interactive_data_access_and_viz and historical_climate_data_comparisons notebooks to check that changes to data_load.py have not affected any workflows.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• None of the above

To-Do

• Unit tests
  • Existing unit tests are passing
  • If relevant, new unit tests are written (required 80% unit test coverage)
• Documentation
  • Intent of all functions included
  • Complex code commented
  • Functions include NumPy style docstrings
• Naming conventions followed
  • Helper functions hidden with _ before the name
• Any notebooks known to utilize the affected functions are still working
• Black formatting has been utilized
• Tagged/notified 2 reviewers for this PR

[neilSchroeder]

The failing test is almost certainly my fault. I can go in a fix it.

edit: apparently just re-running it worked. yay 🥳

[acordonez]

The failing test is almost certainly my fault. I can go in a fix it.

edit: apparently just re-running it worked. yay 🥳

@neilSchroeder Thanks!

[elehmer]

The failing test is almost certainly my fault. I can go in a fix it.
edit: apparently just re-running it worked. yay 🥳

@neilSchroeder Thanks!

Yeah, sometimes the test environment just doesn't build right. Sigh

[neilSchroeder]

The failing test is almost certainly my fault. I can go in a fix it.
edit: apparently just re-running it worked. yay 🥳

@neilSchroeder Thanks!

Yeah, sometimes the test environment just doesn't build right. Sigh

@elehmer can you take a look at this code and approve?

[elehmer]

The failing test is almost certainly my fault. I can go in a fix it.
edit: apparently just re-running it worked. yay 🥳

@neilSchroeder Thanks!

Yeah, sometimes the test environment just doesn't build right. Sigh

@elehmer can you take a look at this code and approve?

Will try and get to it this afternoon

[elehmer]

Looks really good. If we merge the all_touched PR first we will need to make a test for that option. Thanks

[acordonez]

Looks really good. If we merge the all_touched PR first we will need to make a test for that option. Thanks

@elehmer Can do