-
Notifications
You must be signed in to change notification settings - Fork 10
Feat: automated QA tests #2623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat: automated QA tests #2623
Conversation
a00362f
to
7a7e220
Compare
daca2a0
to
42d81f8
Compare
26388e7
to
5e965cb
Compare
I was looking over the open pull requests just now and noticed this PR needed to be rebased. It was an easy one, so went ahead and did it. Hopefully we'll have some time in the next slush time to finish this up. |
We had some discussion for this PR, around improving how test config is done as well as adding documentation:
On the config piece, I think it would be well worth it to go ahead and implement a YAML config file, similar to what we do in The blockers have been (1) not having time to spend on this and (2) uncertainty around what the schema of the YAML file should be. This would be great to look at during our in-person workshop day. |
5e965cb
to
46ea7bb
Compare
I had a thought related to our experience with timeouts not really working for some pages... We're currently using the from playwright.sync_api import Page, expect
def test_dev_healthcheck(page: Page):
page.goto("/healthcheck")
expect(page.get_by_text("Healthy")).to_be_visible() If we made the small change to use from playwright.async_api import Page, expect
async def test_dev_healthcheck(page: Page):
await page.goto("/healthcheck")
await expect(page.get_by_text("Healthy")).to_be_visible() |
requires environment variables to be set for username, password, and authenticator secret
No description provided.