Refactor: Class-based views - Eligibility Start #2916
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP(tests) - determine if TestStartView is required. Removed test_start_without_flow since TestFlowSessionRequiredMixin seems to be testing the same functionality. Note that the CBV is still completely covered by the original tests.
github-actions
bot
added
deployment-dev
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
lalver1
commented
May 19, 2025
| # remove the "view" context key added by ContextMixin in | ||
| # https://github.com/django/django/blob/5.2/django/views/generic/base.py#L30 | ||
| # before assertion | ||
| assert set({k: v for k, v in context.items() if k not in "view"}) == set(mock_session.flow().eligibility_start_context) |
There was a problem hiding this comment.
There's a lot going on in this line, let's break it up to make it clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2869
WIP(tests) - determine if TestStartView is required. Removed test_start_without_flow since TestFlowSessionRequiredMixin seems to be testing the same functionality. Note that the CBV is still completely covered by the original tests.