Skip to content

Feat: define Switchio Index and GatewayUrl views #2928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025

Conversation

lalver1
Copy link
Member

@lalver1 lalver1 commented May 16, 2025

Closes #2902

This PR sets up the basic structure of the enrollment_switchio app. It adds two class-based views, IndexView which handles the bare minimum to render the index page and GatewayUrlView which is a placeholder for the future implementation of the Switchio tokenization gateway registration.

Reviewing

You can preview the enrollment_switchio index page by setting up a transit agency with only a Switchio config and running through an enrollment flow. The new views are not reachable from the application yet, but running through the tests using the debugger can be used to verify the behavior of the new views.

@lalver1 lalver1 self-assigned this May 16, 2025
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev back-end Django views, sessions, middleware, models, migrations etc. tests Related to automated testing (unit, UI, integration, etc.) front-end HTML/CSS/JavaScript and Django templates labels May 16, 2025
Copy link

github-actions bot commented May 16, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  benefits/enrollment_switchio
  models.py
  views.py
Project Total  

This report was generated by python-coverage-comment-action

@lalver1 lalver1 marked this pull request as ready for review May 16, 2025 19:59
@lalver1 lalver1 requested a review from a team as a code owner May 16, 2025 19:59
@lalver1 lalver1 force-pushed the refactor/enrollment_switchio-app branch from 6dda1ac to bf120b1 Compare May 21, 2025 19:12
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small test clean up

@lalver1 lalver1 force-pushed the refactor/enrollment_switchio-app branch from bf120b1 to ea2b7b1 Compare May 21, 2025 21:24
@lalver1 lalver1 marked this pull request as draft May 21, 2025 21:24
@lalver1
Copy link
Member Author

lalver1 commented May 21, 2025

Putting this in Draft until it is rebased on #2930.

@lalver1 lalver1 force-pushed the refactor/enrollment_switchio-app branch 2 times, most recently from 728db2a to 5ba74cc Compare May 27, 2025 19:11
@lalver1
Copy link
Member Author

lalver1 commented May 27, 2025

Rebased on main (which now includes #2930) and ready for review.

@lalver1 lalver1 marked this pull request as ready for review May 27, 2025 19:28
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks @lalver1 🙏

IndexView currently handles the bare minimum to render the index page
for the enrollment_switchio app. GatewayUrlView is a placeholder for
the future implementation of the Switchio tokenization
gateway registration.
As a result of how IndexView is implemented, remove unnecessary
context methods from the SwitchioConfig model.
@lalver1 lalver1 force-pushed the refactor/enrollment_switchio-app branch from 5ba74cc to 24148a0 Compare May 27, 2025 21:03
@angela-tran angela-tran requested a review from thekaveman May 29, 2025 20:08
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry didn't realize I was blocking this!

@lalver1
Copy link
Member Author

lalver1 commented May 30, 2025

No worries! I also overlooked following up on it 😅

@lalver1 lalver1 merged commit 60317f0 into main May 30, 2025
14 checks passed
@lalver1 lalver1 deleted the refactor/enrollment_switchio-app branch May 30, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create enrollment_switchio app
3 participants