Feat: define Switchio Index and GatewayUrl views #2928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
deployment-dev
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
angela-tran
requested changes
May 16, 2025
angela-tran
reviewed
May 16, 2025
angela-tran
reviewed
May 16, 2025
angela-tran
reviewed
May 16, 2025
lalver1
force-pushed
the
refactor/enrollment_switchio-app
branch
from
e3f015f to
6dda1ac
Compare
thekaveman
reviewed
May 20, 2025
angela-tran
reviewed
May 20, 2025
lalver1
force-pushed
the
refactor/enrollment_switchio-app
branch
from
6dda1ac to
bf120b1
Compare
lalver1
force-pushed
the
refactor/enrollment_switchio-app
branch
from
bf120b1 to
ea2b7b1
Compare
|
Putting this in Draft until it is rebased on #2930. |
This was referenced May 21, 2025
lalver1
force-pushed
the
refactor/enrollment_switchio-app
branch
2 times, most recently
from
728db2a to
5ba74cc
Compare
|
Rebased on |
angela-tran
approved these changes
May 27, 2025
IndexView currently handles the bare minimum to render the index page for the enrollment_switchio app. GatewayUrlView is a placeholder for the future implementation of the Switchio tokenization gateway registration. As a result of how IndexView is implemented, remove unnecessary context methods from the SwitchioConfig model.
lalver1
force-pushed
the
refactor/enrollment_switchio-app
branch
from
5ba74cc to
24148a0
Compare
thekaveman
approved these changes
May 29, 2025
|
No worries! I also overlooked following up on it 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2902
This PR sets up the basic structure of the
enrollment_switchioapp. It adds two class-based views,IndexViewwhich handles the bare minimum to render the index page andGatewayUrlViewwhich is a placeholder for the future implementation of the Switchio tokenization gateway registration.Reviewing
You can preview theThe new views are not reachable from the application yet, but running through the tests using the debugger can be used to verify the behavior of the new views.enrollment_switchioindex page by setting up a transit agency with only a Switchio config and running through an enrollment flow.