-
Notifications
You must be signed in to change notification settings - Fork 10
Feat: define Switchio Index and GatewayUrl views #2928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
e3f015f
to
6dda1ac
Compare
6dda1ac
to
bf120b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small test clean up
bf120b1
to
ea2b7b1
Compare
Putting this in Draft until it is rebased on #2930. |
728db2a
to
5ba74cc
Compare
Rebased on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks @lalver1 🙏
IndexView currently handles the bare minimum to render the index page for the enrollment_switchio app. GatewayUrlView is a placeholder for the future implementation of the Switchio tokenization gateway registration. As a result of how IndexView is implemented, remove unnecessary context methods from the SwitchioConfig model.
5ba74cc
to
24148a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry didn't realize I was blocking this!
No worries! I also overlooked following up on it 😅 |
Closes #2902
This PR sets up the basic structure of the
enrollment_switchio
app. It adds two class-based views,IndexView
which handles the bare minimum to render the index page andGatewayUrlView
which is a placeholder for the future implementation of the Switchio tokenization gateway registration.Reviewing
You can preview theThe new views are not reachable from the application yet, but running through the tests using the debugger can be used to verify the behavior of the new views.enrollment_switchio
index page by setting up a transit agency with only a Switchio config and running through an enrollment flow.