Feat: Switchio registration module #2936
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
back-end
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||
angela-tran
force-pushed
the
feat/switchio-registration-module
branch
2 times, most recently
from
c6e45d5 to
0d47234
Compare
assuming you have the correct values for the referenced env variables, this code will successfully connect to the Switchio registration API. this is the code used during research / prototyping.
replace the API-related global variables with function parameters
angela-tran
force-pushed
the
feat/switchio-registration-module
branch
from
d87fd1d to
1c4b36f
Compare
thekaveman
reviewed
May 28, 2025
| headers=self._get_headers(method="POST", request_path=registration_path, request_body=request_body), | ||
| cert=cert, | ||
| verify=self.ca_certificate, | ||
| timeout=timeout, |
There was a problem hiding this comment.
We have settings.REQUESTS_TIMEOUT for this purpose.
There was a problem hiding this comment.
Ah, I think this is eventually intended to move out into its own package, right? 👍
There was a problem hiding this comment.
Right, this is meant to be used by Benefits code which would be responsible for passing in settings.REQUEST_TIMEOUT.
| response.raise_for_status() | ||
|
|
||
| registration_id = response.json()["regId"] | ||
| gateway_url = response.json()["gtwUrl"] |
There was a problem hiding this comment.
Nit: feels a little strange to parse the response to JSON twice. Maybe not.
have the `request_registration` function return an instance of the class
add function parameter for this value
values are expected to be set in your .env file
this required some small refactors to Client methods.
angela-tran
force-pushed
the
feat/switchio-registration-module
branch
from
1c4b36f to
8720aff
Compare
add type hints to code to help clarify input types.
remove an unnecessary method parameter from Client method. it can use the instance variable directly.
|
Closing this PR to keep it as documentation of prior research work. Will open a new PR with less granular commits |
3 tasks
|
Superseded by #2946 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2903