Skip to content

Modified the tool versions and the test suite - #48

Open
ahanag22 wants to merge 7 commits into
calabash:masterfrom
ahanag22:master
Open

Modified the tool versions and the test suite #48
ahanag22 wants to merge 7 commits into
calabash:masterfrom
ahanag22:master

Conversation

@ahanag22

Copy link
Copy Markdown
  • Updated UITest and NUnit to the latest versions.

  • Modified the Test Suite so that each dialog is part of a separate [Test] instead of the same [Test]. The reason being because if say, Background Location fails but Push Notifications would pass; it wouldn't be able to tell in the current set up because the test would fail before it gets the chance to test Push notifications.

- Updated UITest and NUnit to the latest versions.

- Modified the Test Suite so that each dialog is part of a separate [Test] instead of the same [Test]. The reason being because if say, Background Location fails but Push Notifications would pass;  it wouldn't be able to tell in the current set up because the test would fail before it gets the chance to test Push notifications.
@ahanag22 ahanag22 changed the title updated the tool versions and modified the test suite Modified the tool versions and the test suite Oct 10, 2019
@jmoody

jmoody commented Oct 11, 2019

Copy link
Copy Markdown
Contributor

@ahanag22 Hey! Excited to see this! Let me know if you need help resolving the merge conflicts in the Xcode project file.

@ahanag22

Copy link
Copy Markdown
Author

The conflicts were in Xcode project file and were very straight-forward to resolve(both of them were versions changes). I resolved them using the merge tool.

@ahanag22

Copy link
Copy Markdown
Author

@jmoody I'm not sure why the build is failing. My local branch is working fine without throwing any exceptions. Do you have any advice?

@jmoody

jmoody commented Oct 15, 2019

Copy link
Copy Markdown
Contributor

I think you should make a branch off the calabash/Permissions repo and not from your fork. I will invite you now to the maintainers group (if you are not already a member).

The failure is because the signing keychain cannot be created because (presumably) your VSTS user does not have permission to use the Variable Group that is connected to Key Vault that contains the GitHub API token...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants