Prepping for 3.7.1 (#578)

Author: rmpowell77

README.md

@@ -56,6 +56,49 @@ If you need to regenerate the help documentation, see the [README-docs.txt](READ
 
 
 # Release notes
+## Release notes for 3.7.1
+
+Bugs addressed in this release:
+
+* [#443](../../issues/443) Dark Mode doesn't show status bar on Mac
+* [#462](../../issues/462) PDF printing of Continuities seems wrong
+* [#497](../../issues/497) Animate ctor should be explicit
+* [#518](../../issues/518) Animation looks wrong
+* [#540](../../issues/540) Current 3.7.1 does not run
+* [#542](../../issues/542) crashes when going to last sheet of animation in RAINBOW show
+* [#544](../../issues/544) Print Continuity text is not showing up
+
+Other changes:
+
+* [#492](../../issues/492) calchart_cmd should have an option for dumping json
+* [#494](../../issues/494) Refine the calchart_cmd for dump_continuity_text
+* [#498](../../issues/498) remove GetAnimation
+* [#500](../../issues/500) Add JSON tests to sanity tests
+* [#502](../../issues/502) remove get animation sheet iterator
+* [#504](../../issues/504) Make Animation::NextBeat private
+* [#506](../../issues/506) remove index from AnimateInfo
+* [#510](../../issues/510) Switch the underlying Coord system to int32
+* [#512](../../issues/512) Animation commands should contain the position, not the beat
+* [#514](../../issues/514) Make Animation part of the Show, with access through the show
+* [#521](../../issues/521) Degree should have special constructors for common directions
+* [#526](../../issues/526) We should have a sanity test for ps output
+* [#528](../../issues/528) Clean up postscript files to be more value like
+* [#530](../../issues/530) Tidy up CalChartShow.h
+* [#532](../../issues/532) tidy up CalChartFileFormat
+* [#534](../../issues/534) remove unused Token from Continuity parsing
+* [#536](../../issues/536) Change the animation objects to be within the Animate namespace
+* [#538](../../issues/538) Remove unused cont symbol from animate errors
+* [#546](../../issues/546) Change behavior of show generation so endPosition and nextPosition in animation are the same
+* [#547](../../issues/547) Add some basic profiling to calband_cmd
+* [#550](../../issues/550) Make animation compilation an operation of two pairs of sheets
+* [#552](../../issues/552) Move GenerateModeDrawCommands from CalChartDrawing to core/Mode
+* [#554](../../issues/554) Move General printing over to PrintContUseNewDraw
+* [#557](../../issues/557) Move Config into DrawPoints
+* [#563](../../issues/563) Print doesn't show continuity correct
+* [#565](../../issues/565) Move more drawing into Show and ShowDoc
+* [#567](../../issues/567) Remove GetCurrentSheet() from CalChartView
+* [#570](../../issues/570) Tidy up CalChart View
+
 ## Release notes for 3.7.0
 
 Bugs addressed in this release:

RELEASE_INSTRUCTIONS.md

@@ -13,46 +13,56 @@ Checklist
 
 CalChart uses CMake and Github actions to automate the release process.  When you push a tag for the repository, github will build and package the release.
 
-The current calchart version is 3.7.0.  In all commands below, substitute that number for `$CCVER` (meaning when you read `$CCVER`, type 3.7.0)
+The current calchart version is 3.7.1.  In all commands below, substitute that number for `$CCVER` (meaning when you read `$CCVER`, type 3.7.1)
 
- 1. Prebuild the project to make sure its working
+ 1. Create a git branch to prep the changes: `git diff dev/prep_$CCVER`
 
- 2. Update LATEST_RELEASE_NOTES.md with all the changes (it will get posted to the release by our CI bot)
+ 2. Prebuild the project to make sure its working
 
- 3. copy LATEST_RELEASE_NOTES.md into master README.md for the master record via this command:
+ 3. Update LATEST_RELEASE_NOTES.md with all the changes (it will get posted to the release by our CI bot)
+
+ 4. copy LATEST_RELEASE_NOTES.md into master README.md for the master record via this command:
 
 ```
 awk '//; /^# Release notes/{while(getline<"LATEST_RELEASE_NOTES.md"){print}}' README.md > tmp && mv tmp README.md
 ```
 
- 4. Tag the depot
+ 5. Merge the branch into main
+
+ 6. Tag the depot
 
 ```
-$ git tag -a v3.7.0 -m "calchart-3.7.0"
-$ git push origin v3.7.0
+$ git tag -a v3.7.1 -m "calchart-3.7.1"
+$ git push origin v3.7.1
 ```
 
 This should trigger the github action, which should publish release notes in Draft form.
 
- 5. Once the Release information looks good, Press the Publish Release button.
+ 7. Once the Release information looks good, Press the Publish Release button.
+
+ 8. Download the Release artifacts to your machine.
+
+ 9. Go to the sourceforge page at http://sourceforge.net/projects/calchart.  You'll need to be logged in as Administrator to modify the files.
+
+ 10. Go to Project Admin -> File Manager
 
- 6. Download the Release artifacts to your machine.
+ 11. Make a new directory for this version (click on the * next to root)
 
- 7. Go to the sourceforge page at http://sourceforge.net/projects/calchart.  You'll need to be logged in as Administrator to modify the files.
+ 12. Upload the `README.md` to the new folder.  Click on `README.md` and edit the file details to signify it's a release notes.
 
- 8. Go to Project Admin -> File Manager
+ 13. Upload the `CalChart-$CCVER.dmg` to the folder.  Click on dmg and edit the file details to signify its platform is Mac (OS X) and set the release_notes for the file.
 
- 9. Make a new directory for this version (click on the * next to root)
+ 14. Repeat for `Install-CalChart-$CCVER.exe`.  Click on zip and edit the file details to signify its platform is Windows and set the release_notes for the file.
 
- 10. Upload the `README.md` to the new folder.  Click on `README.md` and edit the file details to signify it's a release notes.
+ 15. Update https://github.com/calband/calchart/milestone by closing the shipped milestone and starting the next one.
 
- 11. Upload the `CalChart-$CCVER.dmg` to the folder.  Click on dmg and edit the file details to signify its platform is Mac (OS X) and set the release_notes for the file.
+ 16. Create a git branch to pre-prep the next version: `git diff dev/pre_prep_$CCVER+1`
 
- 12. Repeat for `Install-CalChart-$CCVER.exe`.  Click on zip and edit the file details to signify its platform is Windows and set the release_notes for the file.
+ 17. Clear out LATEST_RELEASE_NOTES.md for next development effort. Update $CCVER+1 in RELEASE_INSTRUCTIONS.md.
 
- 13. Update https://github.com/calband/calchart/milestone by closing the shipped milestone and starting the next one.
+ 18. Merge dev/pre_prep
 
- 14. Notify the world about the new version of CalChart.
+ 19. Notify the world about the new version of CalChart.
 
- 15. Have a cookie.
+ 20. Have a cookie.
 

src/CalChartFrame.cpp

@@ -1291,7 +1291,7 @@ wxString CalChartFrame::BeatStatusText() const
 
 wxString CalChartFrame::PointStatusText() const
 {
-    auto show = GetShow();
+    auto const* show = GetShow();
     wxString result;
     auto sl = show->GetSelectionList();
     result << show->GetSelectionList().size() << " of "

src/core/CalChartSheet.cpp

@@ -518,7 +518,7 @@ auto Sheet::FindMarcher(Coord where, Coord::units searchBound, unsigned ref) con
             return i;
         }
     }
-    return -1;
+    return std::nullopt;
 }
 
 SelectionList Sheet::MakeSelectPointsBySymbol(SYMBOL_TYPE i) const