[Offline Functionality] Refresh Site Data after Emptying Replay Queue#146
Open
julianrkung wants to merge 2 commits intomainfrom
Open
[Offline Functionality] Refresh Site Data after Emptying Replay Queue#146julianrkung wants to merge 2 commits intomainfrom
julianrkung wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in this PR
This PR implements a channel for the service worker and client to communicate. This is used to trigger a data refresh once all requests stored offline have finished being replayed. We only refresh once the queue is fully empty in order to not lose any offline objects in the redux store that would otherwise be lost if we refreshed site data with requests still queued.
How to review
npm run buildto build a production environmentserve -s buildto run the production environmentusername: admin ; password: test.Offline requests finished sending. Refreshing data...log messageRelevant Links
Online sources
https://developers.google.com/web/tools/workbox/reference-docs/latest/module-workbox-background-sync.Queue
Related PRs
Next steps
Screenshots
CC: @julianrkung