-
Notifications
You must be signed in to change notification settings - Fork 3
[feat] Implement task management system functionality #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[feat] Implement task management system functionality #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
holy shit massive PR but everything seems to work apart from the bugs i mentioned. you're gonna have to walk me thru the changes too. no styling comments this time since its the next PR but really good job man this works really well good shit
This comment was marked as outdated.
This comment was marked as outdated.
1d270da
to
cb16f89
Compare
5070891
to
6649820
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works pretty well, haven't run into bugs so far. i think the only issue is with how we are currently setting dates using either new Date() or toISOString. we should try to avoid toISOString wherever possible because it converts the datestring into UTC 0 time, affecting the actual date itself. try using dayjs to avoid this. other than that works really well, good job!
…ttps://github.com/calblueprint/trap-garden into 95-implement-task-management-system-functionality
…ttps://github.com/calblueprint/trap-garden into 95-implement-task-management-system-functionality
What's new in this PR 🧑🌾
Description
The general premise of this sprint was basically to allow the users to properly track harvesting, weeding, and watering tasks.
Without going into the details here are the general implementations:
Screenshots
How to review
Next steps
As Kyle mentioned, it might be better to have a separate tasks table instead of all the additional columns on user plants
Relevant links
Online sources
Related PRs
CC: @kylezryr