[feat] Add global loading indicators #126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylezryr
requested changes
Apr 28, 2025
Collaborator
kylezryr
left a comment
kylezryr
left a comment
There was a problem hiding this comment.
works well, dw too much about edge cases. the nav column closing too early is def a noticeable problem tho, could we look into that? more specifically, the nav column closes after clicking an item but no loading indication is shown for a couple of seconds. good job otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR 🧑🌾
Description
this was so odd
Screenshots
How to review
Next steps
Relevant links
Online sources
Related PRs
CC: @kylezryr