fix: e2e flakes #20630
Merged
fix: e2e flakes #20630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Contributor
E2E results are ready! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
mrge found 1 issue across 2 files. Review it in mrge.io
| // below which checks for data-state="checked" and works as expected | ||
| await page.waitForSelector(`[data-testid=two-factor-switch]`); | ||
| await expect(page.locator(`[data-testid=two-factor-switch]`).isChecked()).toBeTruthy(); | ||
| await expect(page.getByTestId("backup-codes-download")).toBeVisible(); |
Contributor
There was a problem hiding this comment.
Assertion may not be sufficient to verify 2FA is enabled. The backup codes download button is visible during setup, but doesn't confirm the switch state.
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (05/07/25)1 reviewer was added to this PR based on Keith Williams's automation. |
retrogtx
approved these changes
May 7, 2025
alishaz-polymath
pushed a commit
that referenced
this pull request
May 9, 2025
* fix * Update managed-event-types.e2e.ts * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
WIP