Skip to content

ci: remove deprecated submodule code #20731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

zomars
Copy link
Member

@zomars zomars commented Apr 16, 2025

Summary by mrge

Removed the automated GitHub workflow that periodically synced submodules. This eliminates the scheduled task that previously ran every 4 hours to update submodule references.

Refactors

  • Removed the submodule-sync.yml workflow file that was responsible for automatic submodule updates.
  • Eliminated the scheduled cron job that ran every 4 hours to check and update submodules.
  • Removed the automated commit and push process for submodule reference updates.

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@graphite-app graphite-app bot requested a review from a team April 16, 2025 18:58
@keithwillcode keithwillcode added core area: core, team members only foundation labels Apr 16, 2025
@dosubot dosubot bot added the ci area: CI, DX, pipeline, github actions label Apr 16, 2025
Copy link

graphite-app bot commented Apr 16, 2025

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (04/16/25)

1 reviewer was added to this PR based on Keith Williams's automation.

Signed-off-by: Omar López <[email protected]>
Copy link

vercel bot commented Apr 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2025 1:40pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2025 1:40pm

@zomars zomars changed the title ci: remove submodule sync workflow ci: remove deprecated submodule code Apr 16, 2025
@zomars zomars enabled auto-merge (squash) April 16, 2025 19:04
Copy link
Contributor

github-actions bot commented Apr 16, 2025

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci area: CI, DX, pipeline, github actions core area: core, team members only foundation ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants