fix: Host schedule not updating upon updating/deleting default schedule #20750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
![mrge-io[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (04/17/25)1 reviewer was added to this PR based on Keith Williams's automation. |
hbjORbj
reviewed
Apr 17, 2025
Comment on lines
+59
to
+60
| } else { | ||
| if (user.defaultScheduleId) { |
hbjORbj
requested changes
Apr 17, 2025
dosubot
bot
added
the
bookings
| @@ -45,6 +46,8 @@ export const deleteHandler = async ({ input, ctx }: DeleteOptions) => { | |||
| // to throw the error if there arent any other schedules | |||
| if (!scheduleToSetAsDefault) throw new TRPCError({ code: "BAD_REQUEST" }); | |||
|
|
|||
| await updateHostsWithNewDefaultSchedule(user.id, input.scheduleId, scheduleToSetAsDefault.id, prisma); | |||
There was a problem hiding this comment.
Missing error handling around this async operation could lead to inconsistent state if it fails
| @@ -45,6 +46,8 @@ | |||
| // to throw the error if there arent any other schedules | |||
| if (!scheduleToSetAsDefault) throw new TRPCError({ code: "BAD_REQUEST" }); | |||
|
|
|||
| await updateHostsWithNewDefaultSchedule(user.id, input.scheduleId, scheduleToSetAsDefault.id, prisma); | |||
There was a problem hiding this comment.
Consider using a database transaction for related database operations to ensure atomicity
hbjORbj
requested changes
Apr 21, 2025
| scheduleId: number, | ||
| prisma: PrismaClient | ||
| ) => { | ||
| return prisma.host.updateMany({ |
There was a problem hiding this comment.
We don't want to use prisma directly in trpc routers
We should create a repository function and use that here
auto-merge was automatically disabled
April 21, 2025 15:00
Pull request was converted to draft
E2E results are ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by mrge
Fixed host schedule synchronization to properly update when default schedules are changed, deleted, or updated.
Bug Fixes
setupHostDefaultSchedulefunction to ensure host schedules stay in sync with user default schedules