-
Notifications
You must be signed in to change notification settings - Fork 10k
fix: Host schedule not updating upon updating/deleting default schedule #20750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mrge found 1 issue across 3 files. View it in mrge.io
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (04/17/25)1 reviewer was added to this PR based on Keith Williams's automation. |
packages/trpc/server/routers/viewer/availability/schedule/delete.handler.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than the nit I left
Keith wanted us to write unit tests for each server function we write, can you do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mrge found 2 issues across 3 files. View them in mrge.io
packages/trpc/server/routers/viewer/availability/schedule/delete.handler.ts
Outdated
Show resolved
Hide resolved
packages/trpc/server/routers/viewer/availability/schedule/delete.handler.ts
Outdated
Show resolved
Hide resolved
Pull request was converted to draft
E2E results are ready! |
This PR is being marked as stale due to inactivity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cubic reviewed 4 files and found no issues. Review PR in cubic.dev.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As already mentioned, we don't want to use prisma directly in trpc routers
We should create a repository function and use that here
Pull request was converted to draft
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cubic found 1 issue across 5 files. Review it in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai
to give specific feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, much cleaner! Thanks for addressing feedback
Summary by mrge
Fixed host schedule synchronization to properly update when default schedules are changed, deleted, or updated.
Bug Fixes
setupHostDefaultSchedule
function to ensure host schedules stay in sync with user default schedules