Skip to content

fix: Host schedule not updating upon updating/deleting default schedule #20750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 23, 2025

Conversation

anikdhabal
Copy link
Contributor

@anikdhabal anikdhabal commented Apr 17, 2025

Summary by mrge

Fixed host schedule synchronization to properly update when default schedules are changed, deleted, or updated.

Bug Fixes

  • Added setupHostDefaultSchedule function to ensure host schedules stay in sync with user default schedules
  • Updated delete and update handlers to call the new function when schedule changes occur

@graphite-app graphite-app bot requested a review from a team April 17, 2025 10:50
@keithwillcode keithwillcode added the core area: core, team members only label Apr 17, 2025
@dosubot dosubot bot added the 🐛 bug Something isn't working label Apr 17, 2025
Copy link

vercel bot commented Apr 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview May 23, 2025 7:45am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview May 23, 2025 7:45am

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mrge found 1 issue across 3 files. View it in mrge.io

Copy link

graphite-app bot commented Apr 17, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/17/25)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the nit I left

Keith wanted us to write unit tests for each server function we write, can you do that?

@github-actions github-actions bot marked this pull request as draft April 17, 2025 16:23
@hbjORbj hbjORbj marked this pull request as ready for review April 17, 2025 16:24
@hbjORbj hbjORbj enabled auto-merge (squash) April 17, 2025 16:24
@dosubot dosubot bot added the bookings area: bookings, availability, timezones, double booking label Apr 17, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mrge found 2 issues across 3 files. View them in mrge.io

@github-actions github-actions bot marked this pull request as draft April 21, 2025 15:00
auto-merge was automatically disabled April 21, 2025 15:00

Pull request was converted to draft

Copy link
Contributor

github-actions bot commented Apr 21, 2025

E2E results are ready!

Copy link
Contributor

github-actions bot commented May 8, 2025

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label May 8, 2025
@anikdhabal anikdhabal marked this pull request as ready for review May 22, 2025 05:28
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic reviewed 4 files and found no issues. Review PR in cubic.dev.

Copy link
Contributor

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As already mentioned, we don't want to use prisma directly in trpc routers

We should create a repository function and use that here

@github-actions github-actions bot marked this pull request as draft May 22, 2025 14:26
auto-merge was automatically disabled May 22, 2025 14:26

Pull request was converted to draft

@anikdhabal anikdhabal marked this pull request as ready for review May 23, 2025 05:02
@anikdhabal anikdhabal requested a review from hbjORbj May 23, 2025 05:02
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic found 1 issue across 5 files. Review it in cubic.dev

React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.

Copy link
Contributor

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, much cleaner! Thanks for addressing feedback

@hbjORbj hbjORbj merged commit ef18445 into main May 23, 2025
41 checks passed
@hbjORbj hbjORbj deleted the host-schedule branch May 23, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working core area: core, team members only ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants