-
Notifications
You must be signed in to change notification settings - Fork 9.3k
fix: flaky e2e test #20757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: flaky e2e test #20757
Conversation
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (04/17/25)1 reviewer was added to this PR based on Keith Williams's automation. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mrge reviewed 3 files and found no issues. View the review in mrge.io
@anikdhabal apparently, this isn't fixing it. It's annoying |
Pull request was converted to draft
E2E results are ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is failing. As we discussed, there's inconsistency with this meta tag in our app as well, especially on the /user page. And it's not just the 'robots' tag — I found inconsistency with other meta tags too
bfeb7c6
to
e54ff0b
Compare
e54ff0b
to
ad0a0de
Compare
Summary by mrge
Fixed flaky end-to-end tests by adding fallback values to SEO indexing settings across booking page components.
Bug Fixes
|| false
fallback to allrobots
metadata settings to ensure consistent behavior when values are undefined.Mandatory Tasks (DO NOT REMOVE)
How should this be tested?