Skip to content

fix: flaky e2e test #20757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: flaky e2e test #20757

wants to merge 2 commits into from

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Apr 17, 2025

Summary by mrge

Fixed flaky end-to-end tests by adding fallback values to SEO indexing settings across booking page components.

Bug Fixes

  • Added || false fallback to all robots metadata settings to ensure consistent behavior when values are undefined.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Please use the latest Vercel preview and test please 🙏.

@graphite-app graphite-app bot requested a review from a team April 17, 2025 18:50
Copy link

graphite-app bot commented Apr 17, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/17/25)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link

vercel bot commented Apr 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2025 9:47pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2025 9:47pm

@keithwillcode keithwillcode added core area: core, team members only foundation labels Apr 17, 2025
@hbjORbj hbjORbj enabled auto-merge (squash) April 17, 2025 18:50
@dosubot dosubot bot added the automated-tests area: unit tests, e2e tests, playwright label Apr 17, 2025
Copy link

@mrge-io mrge-io bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mrge reviewed 3 files and found no issues. View the review in mrge.io

anikdhabal
anikdhabal previously approved these changes Apr 17, 2025
@hbjORbj
Copy link
Contributor Author

hbjORbj commented Apr 17, 2025

@anikdhabal apparently, this isn't fixing it. It's annoying

@hbjORbj hbjORbj marked this pull request as draft April 17, 2025 19:28
auto-merge was automatically disabled April 17, 2025 19:28

Pull request was converted to draft

Copy link
Contributor

github-actions bot commented Apr 17, 2025

E2E results are ready!

Copy link
Contributor

@anikdhabal anikdhabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is failing. As we discussed, there's inconsistency with this meta tag in our app as well, especially on the /user page. And it's not just the 'robots' tag — I found inconsistency with other meta tags too

@hbjORbj hbjORbj force-pushed the fix/flaky-e2e-test branch from e54ff0b to ad0a0de Compare April 19, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated-tests area: unit tests, e2e tests, playwright core area: core, team members only foundation ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants