Skip to content

fix: stripe integration in EventTypeSettings atom #20919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: stripe integration in EventTypeSettings atom #20919

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9453aa9
fallback to depreceated installed property in case everything else is…
Ryukemeister Apr 23, 2025
5a36d64
Merge branch 'main' into fix-broken-stripe-integration-for-event-type…
Ryukemeister Apr 23, 2025
6b9f99b
using nullish OR instead of nullish coalescing operator
Ryukemeister Apr 24, 2025
54c0448
Merge branch 'main' into fix-broken-stripe-integration-for-event-type…
Ryukemeister Apr 24, 2025
192da7b
Merge branch 'main' into fix-broken-stripe-integration-for-event-type…
ThyMinimalDev Apr 24, 2025
8325610
fixup
Ryukemeister Apr 25, 2025
2a29d7e
Merge branch 'main' into fix-broken-stripe-integration-for-event-type…
Ryukemeister Apr 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions apps/api/v2/src/modules/atoms/services/event-types-atom.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,20 +226,26 @@ export class EventTypesAtomService {
} else {
credentials = credentials.concat(teamAppCredentials);
}
} else {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing rationale for special treatment of Stripe integration in comments

if (slug !== "stripe") {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider inverting the condition to return early and reduce nesting

// We only add delegationCredentials if the request for location options is for a user because DelegationCredential Credential is applicable to Users only.
const { credentials: allCredentials } =
await enrichUserWithDelegationConferencingCredentialsWithoutOrgId({
user: {
...user,
credentials,
},
});
credentials = allCredentials;
}
}
// We only add delegationCredentials if the request for location options is for a user because DelegationCredential Credential is applicable to Users only.
const { credentials: allCredentials } = await enrichUserWithDelegationConferencingCredentialsWithoutOrgId(

const enabledApps = await getEnabledAppsFromCredentials(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type assertion from credentials to CredentialDataWithTeamName[] is a code smell that suggests a type mismatch. Consider fixing the types properly.

credentials as unknown as CredentialDataWithTeamName[],
{
user: {
...user,
credentials,
},
where: { slug },
}
);
credentials = allCredentials;
const enabledApps = await getEnabledAppsFromCredentials(allCredentials, {
where: { slug },
});
const apps = await Promise.all(
enabledApps
.filter(({ ...app }) => app.slug === slug)
Expand Down
Loading