Skip to content

feat: add membership creation date to Organization Member List table (CAL-5406) #21008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Apr 28, 2025

This reverts #20978 and adds a fix (ba6cf08).

It wrongly back-filled createdAt of membership for all the existing rows, while we just wanted to have the default value for the newly added rows.

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Summary by mrge

Added "Member Since" and "Last Updated" columns to the Organization Member List table, showing when each member joined and when their membership was last updated. These columns support date range filtering.

  • Database Changes
    • Added createdAt and updatedAt fields to the Membership table.

Copy link

linear bot commented Apr 28, 2025

@github-actions github-actions bot added the ❗️ migrations contains migration files label Apr 28, 2025
@keithwillcode keithwillcode added consumer core area: core, team members only labels Apr 28, 2025
Copy link

vercel bot commented Apr 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Apr 28, 2025 2:07pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Apr 28, 2025 2:07pm

Copy link
Contributor

github-actions bot commented Apr 28, 2025

E2E results are ready!

@eunjae-lee eunjae-lee marked this pull request as ready for review April 29, 2025 08:05
@eunjae-lee eunjae-lee requested review from a team as code owners April 29, 2025 08:05
@graphite-app graphite-app bot requested a review from a team April 29, 2025 08:05
@dosubot dosubot bot added organizations area: organizations, orgs ✨ feature New feature or request labels Apr 29, 2025
Copy link

graphite-app bot commented Apr 29, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/29/25)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link

@mrge-io mrge-io bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mrge found 14 issues across 29 files. View them in mrge.io

Copy link
Contributor

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only ✨ feature New feature or request ❗️ migrations contains migration files organizations area: organizations, orgs ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants