-
Notifications
You must be signed in to change notification settings - Fork 9.3k
feat: add membership creation date to Organization Member List table (CAL-5406) #21008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…(CAL-5406) This reverts commit 5aaca2b.
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
E2E results are ready! |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (04/29/25)1 reviewer was added to this PR based on Keith Williams's automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mrge found 14 issues across 29 files. View them in mrge.io
apps/api/v2/src/modules/teams/memberships/teams-memberships.repository.ts
Show resolved
Hide resolved
packages/prisma/migrations/20250407204810_add_membership_creation_date/migration.sql
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets go!
This reverts #20978 and adds a fix (ba6cf08).
It wrongly back-filled createdAt of membership for all the existing rows, while we just wanted to have the default value for the newly added rows.
What does this PR do?
Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
Image Demo (if applicable):
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist
Summary by mrge
Added "Member Since" and "Last Updated" columns to the Organization Member List table, showing when each member joined and when their membership was last updated. These columns support date range filtering.
createdAt
andupdatedAt
fields to the Membership table.