fix: disallow undefined where clause #21062
Draft
+176
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (05/01/25)1 reviewer was added to this PR based on Keith Williams's automation. |
anikdhabal
commented
May 1, 2025
Comment on lines
45
to
56
| $allModels: { | ||
| async deleteMany({ args, query }) { | ||
| checkUndefinedInValue(args.where); | ||
| validateWhereClause(args.where); | ||
| return query(args); | ||
| }, | ||
| async updateMany({ args, query }) { | ||
| checkUndefinedInValue(args.where); | ||
| validateWhereClause(args.where); | ||
| return query(args); | ||
| }, | ||
| async findMany({ args, query }) { | ||
| validateWhereClause(args.where); | ||
| return query(args); |
There was a problem hiding this comment.
Currently, we have this guard for these operations. Do we need to add more operations here?
anikdhabal
commented
May 2, 2025
Comment on lines
+62
to
+91
| it("validateWhereClause should throw exception when the where object is undefined", async () => { | ||
| const where = undefined; | ||
|
|
||
| expect(() => validateWhereClause(where)).toThrowError('The "where" clause cannot be undefined.'); | ||
| }); | ||
|
|
||
| it("validateWhereClause should throw exception when the where object is {}", async () => { | ||
| const where = {}; | ||
|
|
||
| expect(() => validateWhereClause(where)).toThrowError('The "where" clause cannot be an empty object {}.'); | ||
| }); | ||
|
|
||
| it("validateWhereClause should throw exception when the where object is []", async () => { | ||
| const where = []; | ||
|
|
||
| expect(() => validateWhereClause(where)).toThrowError('The "where" clause cannot be an empty array [].'); | ||
| }); | ||
|
|
||
| it("validateWhereClause should throw exception when the 'in' field of where object is []", async () => { | ||
| const where = { | ||
| id: { | ||
| in: [], | ||
| }, | ||
| }; | ||
|
|
||
| expect(() => validateWhereClause(where)).toThrowError( | ||
| 'The "in" value for the field "id" cannot be an empty array [].' | ||
| ); | ||
| }); | ||
| }); |
E2E results are ready! |
Udit-takkar
requested changes
May 8, 2025
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
| ); | ||
| }); | ||
|
|
||
| it("validateWhereClause should throw exception when the where object is undefined", async () => { |
There was a problem hiding this comment.
Unnecessary async keyword in test function that doesn't use await
| @@ -0,0 +1,66 @@ | |||
| import { Prisma } from "@prisma/client"; | |||
|
|
|||
| export const validateWhereClause = (where: any) => { | |||
There was a problem hiding this comment.
Using 'any' type reduces type safety and prevents TypeScript from providing helpful errors
|
This PR is being marked as stale due to inactivity. |
|
This PR is being marked as stale due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Summary by mrge
Disallowed undefined, empty object, and empty array values in Prisma where clauses to prevent invalid queries.